[MediaWiki-commits] [Gerrit] Move the arrows and the close/fullscreen button - change (mediawiki...MultimediaViewer)

2014-01-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Move the arrows and the close/fullscreen button
..


Move the arrows and the close/fullscreen button

Looks drastic at first, but grows on you.
I based this on an extreme, the firefox inner scrollbar.
Which is huge when hovered.
I kind of wish the close button was a bit bigger, though.

Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
---
M resources/ext.multimediaViewer/ext.multimediaViewer.css
M resources/multilightbox/multilightbox.css
2 files changed, 13 insertions(+), 7 deletions(-)

Approvals:
  Aarcos: Looks good to me, approved
  Gergő Tisza: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/resources/ext.multimediaViewer/ext.multimediaViewer.css 
b/resources/ext.multimediaViewer/ext.multimediaViewer.css
index 53abdbe..1df5706 100644
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.css
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.css
@@ -324,15 +324,15 @@
 .mw-mlb-next-image {
/* @embed */
background-image: url(img/next-ltr.svg);
-   right: 5px;
background-position: right;
+   right: 18px;
 }
 
 .mw-mlb-prev-image {
/* @embed */
background-image: url(img/prev-ltr.svg);
-   left: 5px;
background-position: left;
+   left: 18px;
 }
 
 .mw-mlb-next-image.disabled,
diff --git a/resources/multilightbox/multilightbox.css 
b/resources/multilightbox/multilightbox.css
index c90cda8..f7304f7 100644
--- a/resources/multilightbox/multilightbox.css
+++ b/resources/multilightbox/multilightbox.css
@@ -79,22 +79,28 @@
 .mlb-close,
 .mlb-fullscreen {
position: absolute;
-   top: 0px;
+   margin-top: 14px;
+   margin-right: 14px;
cursor: pointer;
-   width: 32px;
-   height: 32px;
 }
 
 .mlb-close {
-   left: 0px;
background-image: url(../img/close.svg);
border-right: 1px solid #7d7c81;
+   height: 23px;
+   width: 23px;
 }
 
 .mlb-fullscreen {
-   right: 0px;
background-image: url(../img/fullscreen.svg);
border-left: 1px solid #7d7c81;
+   width: 21px;
+   height: 22px;
+}
+
+.mlb-fullscreen-div .mlb-fullscreen {
+   width: 28px;
+   height: 29px;
 }
 
 .mlb-main.mlb-fullscreened {

-- 
To view, visit https://gerrit.wikimedia.org/r/106224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: Aarcos aarcos.w...@gmail.com
Gerrit-Reviewer: Gergő Tisza gti...@wikimedia.org
Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Move the arrows and the close/fullscreen button - change (mediawiki...MultimediaViewer)

2014-01-08 Thread Gilles (Code Review) 
Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106224


Change subject: Move the arrows and the close/fullscreen button
..

Move the arrows and the close/fullscreen button

Looks drastic at first, but grows on you.
I based this on an extreme, the firefox inner scrollbar.
Which is huge when hovered.
I kind of wish the close button was a bit bigger, though.

Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
---
M resources/ext.multimediaViewer/ext.multimediaViewer.css
M resources/multilightbox/multilightbox.css
2 files changed, 13 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/24/106224/1

diff --git a/resources/ext.multimediaViewer/ext.multimediaViewer.css 
b/resources/ext.multimediaViewer/ext.multimediaViewer.css
index 53abdbe..1df5706 100644
--- a/resources/ext.multimediaViewer/ext.multimediaViewer.css
+++ b/resources/ext.multimediaViewer/ext.multimediaViewer.css
@@ -324,15 +324,15 @@
 .mw-mlb-next-image {
/* @embed */
background-image: url(img/next-ltr.svg);
-   right: 5px;
background-position: right;
+   right: 18px;
 }
 
 .mw-mlb-prev-image {
/* @embed */
background-image: url(img/prev-ltr.svg);
-   left: 5px;
background-position: left;
+   left: 18px;
 }
 
 .mw-mlb-next-image.disabled,
diff --git a/resources/multilightbox/multilightbox.css 
b/resources/multilightbox/multilightbox.css
index c90cda8..f7304f7 100644
--- a/resources/multilightbox/multilightbox.css
+++ b/resources/multilightbox/multilightbox.css
@@ -79,22 +79,28 @@
 .mlb-close,
 .mlb-fullscreen {
position: absolute;
-   top: 0px;
+   margin-top: 14px;
+   margin-right: 14px;
cursor: pointer;
-   width: 32px;
-   height: 32px;
 }
 
 .mlb-close {
-   left: 0px;
background-image: url(../img/close.svg);
border-right: 1px solid #7d7c81;
+   height: 23px;
+   width: 23px;
 }
 
 .mlb-fullscreen {
-   right: 0px;
background-image: url(../img/fullscreen.svg);
border-left: 1px solid #7d7c81;
+   width: 21px;
+   height: 22px;
+}
+
+.mlb-fullscreen-div .mlb-fullscreen {
+   width: 28px;
+   height: 29px;
 }
 
 .mlb-main.mlb-fullscreened {

-- 
To view, visit https://gerrit.wikimedia.org/r/106224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f47280c4e7c4bff299149de24741e3381f0b5e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits