[MediaWiki-commits] [Gerrit] Moved 'recreatedata' RL module to bottom of page - change (mediawiki...Cargo)

2015-09-30 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242627

Change subject: Moved 'recreatedata' RL module to bottom of page
..

Moved 'recreatedata' RL module to bottom of page

Otherwise the JS sometimes breaks, according to the talk page.

Change-Id: I6ab3204eaf9742da0eca92e9571f06a4231aeb53
---
M Cargo.php
M extension.json
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/27/242627/1

diff --git a/Cargo.php b/Cargo.php
index 33a06f0..6f7ff2b 100644
--- a/Cargo.php
+++ b/Cargo.php
@@ -165,7 +165,7 @@
'cargo-recreatedata-tablecreated',
'cargo-recreatedata-success'
),
-   'position' => 'top',
+   'position' => 'bottom',
'localBasePath' => __DIR__,
'remoteExtPath' => 'Cargo'
),
diff --git a/extension.json b/extension.json
index 54a8621..4eaca7a 100644
--- a/extension.json
+++ b/extension.json
@@ -110,7 +110,7 @@
"cargo-recreatedata-tablecreated",
"cargo-recreatedata-success"
],
-   "position": "top"
+   "position": "bottom"
},
"ext.cargo.drilldown": {
"styles": [

-- 
To view, visit https://gerrit.wikimedia.org/r/242627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ab3204eaf9742da0eca92e9571f06a4231aeb53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Moved 'recreatedata' RL module to bottom of page - change (mediawiki...Cargo)

2015-09-30 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged.

Change subject: Moved 'recreatedata' RL module to bottom of page
..


Moved 'recreatedata' RL module to bottom of page

Otherwise the JS sometimes breaks, according to the talk page.

Change-Id: I6ab3204eaf9742da0eca92e9571f06a4231aeb53
---
M Cargo.php
M extension.json
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Checked; Looks good to me, approved



diff --git a/Cargo.php b/Cargo.php
index 33a06f0..6f7ff2b 100644
--- a/Cargo.php
+++ b/Cargo.php
@@ -165,7 +165,7 @@
'cargo-recreatedata-tablecreated',
'cargo-recreatedata-success'
),
-   'position' => 'top',
+   'position' => 'bottom',
'localBasePath' => __DIR__,
'remoteExtPath' => 'Cargo'
),
diff --git a/extension.json b/extension.json
index 54a8621..4eaca7a 100644
--- a/extension.json
+++ b/extension.json
@@ -110,7 +110,7 @@
"cargo-recreatedata-tablecreated",
"cargo-recreatedata-success"
],
-   "position": "top"
+   "position": "bottom"
},
"ext.cargo.drilldown": {
"styles": [

-- 
To view, visit https://gerrit.wikimedia.org/r/242627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6ab3204eaf9742da0eca92e9571f06a4231aeb53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits