Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222145
Change subject: Only variables may be passed by reference
......................................................................
Only variables may be passed by reference
Change-Id: I0d8f22f8d97c8ef3f72b3c58f4dd79e962d9f35e
---
M php/Element.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/45/222145/1
diff --git a/php/Element.php b/php/Element.php
index 14d2159..7a8cee1 100644
--- a/php/Element.php
+++ b/php/Element.php
@@ -248,7 +248,8 @@
array_walk_recursive( $config, $replaceElements );
// Set '_' last to ensure that subclasses can't accidentally
step on it.
// Strip all namespaces from the class name
- $config['_'] = end( explode( '\\', get_class( $this ) ) );
+ $exploded = explode( '\\', get_class( $this ) );
+ $config['_'] = end( $exploded );
return $config;
}
--
To view, visit https://gerrit.wikimedia.org/r/222145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d8f22f8d97c8ef3f72b3c58f4dd79e962d9f35e
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
