[MediaWiki-commits] [Gerrit] Promote Tabs to production. - change (apps...wikipedia)

2015-07-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Promote Tabs to production.
..


Promote Tabs to production.

almost forgot!

Change-Id: Id254296acfe2755c9aa59a1cb6a0069654beb0ea
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  Mholloway: Looks good to me, but someone else must approve
  Niedzielski: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
index 9864877..25a6b2c 100755
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
@@ -704,12 +704,6 @@
 MenuItem themeChooserMenu = menu.findItem(R.id.menu_themechooser);
 MenuItem tabsMenu = menu.findItem(R.id.menu_show_tabs);
 
-//TODO: enable when ready for production!
-if (app.isProdRelease() && tabsMenu != null) {
-// remove the tabs button in production, for now.
-menu.removeItem(tabsMenu.getItemId());
-}
-
 if (pageLoadStrategy.isLoading()) {
 savePageMenu.setEnabled(false);
 shareMenu.setEnabled(false);

-- 
To view, visit https://gerrit.wikimedia.org/r/227900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id254296acfe2755c9aa59a1cb6a0069654beb0ea
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Promote Tabs to production. - change (apps...wikipedia)

2015-07-29 Thread Dbrant (Code Review) 
Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227900

Change subject: Promote Tabs to production.
..

Promote Tabs to production.

almost forgot!

Change-Id: Id254296acfe2755c9aa59a1cb6a0069654beb0ea
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/00/227900/1

diff --git 
a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
index ae8710b..e15333f 100755
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
@@ -691,12 +691,6 @@
 MenuItem themeChooserMenu = menu.findItem(R.id.menu_themechooser);
 MenuItem tabsMenu = menu.findItem(R.id.menu_show_tabs);
 
-//TODO: enable when ready for production!
-if (app.isProdRelease() && tabsMenu != null) {
-// remove the tabs button in production, for now.
-menu.removeItem(tabsMenu.getItemId());
-}
-
 if (pageLoadStrategy.isLoading()) {
 savePageMenu.setEnabled(false);
 shareMenu.setEnabled(false);

-- 
To view, visit https://gerrit.wikimedia.org/r/227900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id254296acfe2755c9aa59a1cb6a0069654beb0ea
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits