[MediaWiki-commits] [Gerrit] Re-order command registry to match toolbar order - change (mediawiki...VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/98516


Change subject: Re-order command registry to match toolbar order
..

Re-order command registry to match toolbar order

Bonus: fix grammar in DialogAction comment.

Change-Id: I0fdf5f028f7191b0d662456ec1506490d7439a1a
---
M modules/ve/ui/actions/ve.ui.DialogAction.js
M modules/ve/ui/ve.ui.CommandRegistry.js
2 files changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/16/98516/1

diff --git a/modules/ve/ui/actions/ve.ui.DialogAction.js 
b/modules/ve/ui/actions/ve.ui.DialogAction.js
index b65c75e..e1a7aa2 100644
--- a/modules/ve/ui/actions/ve.ui.DialogAction.js
+++ b/modules/ve/ui/actions/ve.ui.DialogAction.js
@@ -37,7 +37,7 @@
 /* Methods */
 
 /**
- * Open an Dialog.
+ * Open a Dialog.
  *
  * @method
  * @param {string} name Symbolic name of Dialog to open
diff --git a/modules/ve/ui/ve.ui.CommandRegistry.js 
b/modules/ve/ui/ve.ui.CommandRegistry.js
index 9b472ca..d418cff 100644
--- a/modules/ve/ui/ve.ui.CommandRegistry.js
+++ b/modules/ve/ui/ve.ui.CommandRegistry.js
@@ -49,16 +49,22 @@
 /* Registrations */
 
 ve.ui.commandRegistry.register(
+   'undo', new ve.ui.Command( 'history', 'undo' )
+);
+ve.ui.commandRegistry.register(
+   'redo', new ve.ui.Command( 'history', 'redo' )
+);
+ve.ui.commandRegistry.register(
'bold', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/bold' )
 );
 ve.ui.commandRegistry.register(
'italic', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/italic' 
)
 );
 ve.ui.commandRegistry.register(
-   'code', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/code' )
+   'link', new ve.ui.Command( 'inspector', 'open', 'link' )
 );
 ve.ui.commandRegistry.register(
-   'strikethrough', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/strike' )
+   'clear', new ve.ui.Command( 'annotation', 'clearAll' )
 );
 ve.ui.commandRegistry.register(
'underline', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/underline' )
@@ -70,25 +76,19 @@
'superscript', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/superscript' )
 );
 ve.ui.commandRegistry.register(
-   'clear', new ve.ui.Command( 'annotation', 'clearAll' )
-);
-ve.ui.commandRegistry.register(
'indent', new ve.ui.Command( 'indentation', 'increase' )
 );
 ve.ui.commandRegistry.register(
'outdent', new ve.ui.Command( 'indentation', 'decrease' )
 );
 ve.ui.commandRegistry.register(
-   'link', new ve.ui.Command( 'inspector', 'open', 'link' )
+   'code', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/code' )
+);
+ve.ui.commandRegistry.register(
+   'strikethrough', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/strike' )
 );
 ve.ui.commandRegistry.register(
'language', new ve.ui.Command( 'inspector', 'open', 'language' )
-);
-ve.ui.commandRegistry.register(
-   'redo', new ve.ui.Command( 'history', 'redo' )
-);
-ve.ui.commandRegistry.register(
-   'undo', new ve.ui.Command( 'history', 'undo' )
 );
 ve.ui.commandRegistry.register(
'paragraph', new ve.ui.Command( 'format', 'convert', 'paragraph' )

-- 
To view, visit https://gerrit.wikimedia.org/r/98516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fdf5f028f7191b0d662456ec1506490d7439a1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Re-order command registry to match toolbar order - change (mediawiki...VisualEditor)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Re-order command registry to match toolbar order
..


Re-order command registry to match toolbar order

Bonus: fix grammar in DialogAction comment.

Change-Id: I0fdf5f028f7191b0d662456ec1506490d7439a1a
---
M modules/ve/ui/actions/ve.ui.DialogAction.js
M modules/ve/ui/ve.ui.CommandRegistry.js
2 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ui/actions/ve.ui.DialogAction.js 
b/modules/ve/ui/actions/ve.ui.DialogAction.js
index b65c75e..e1a7aa2 100644
--- a/modules/ve/ui/actions/ve.ui.DialogAction.js
+++ b/modules/ve/ui/actions/ve.ui.DialogAction.js
@@ -37,7 +37,7 @@
 /* Methods */
 
 /**
- * Open an Dialog.
+ * Open a Dialog.
  *
  * @method
  * @param {string} name Symbolic name of Dialog to open
diff --git a/modules/ve/ui/ve.ui.CommandRegistry.js 
b/modules/ve/ui/ve.ui.CommandRegistry.js
index 9b472ca..d418cff 100644
--- a/modules/ve/ui/ve.ui.CommandRegistry.js
+++ b/modules/ve/ui/ve.ui.CommandRegistry.js
@@ -49,16 +49,22 @@
 /* Registrations */
 
 ve.ui.commandRegistry.register(
+   'undo', new ve.ui.Command( 'history', 'undo' )
+);
+ve.ui.commandRegistry.register(
+   'redo', new ve.ui.Command( 'history', 'redo' )
+);
+ve.ui.commandRegistry.register(
'bold', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/bold' )
 );
 ve.ui.commandRegistry.register(
'italic', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/italic' 
)
 );
 ve.ui.commandRegistry.register(
-   'code', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/code' )
+   'link', new ve.ui.Command( 'inspector', 'open', 'link' )
 );
 ve.ui.commandRegistry.register(
-   'strikethrough', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/strike' )
+   'clear', new ve.ui.Command( 'annotation', 'clearAll' )
 );
 ve.ui.commandRegistry.register(
'underline', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/underline' )
@@ -70,25 +76,19 @@
'superscript', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/superscript' )
 );
 ve.ui.commandRegistry.register(
-   'clear', new ve.ui.Command( 'annotation', 'clearAll' )
-);
-ve.ui.commandRegistry.register(
'indent', new ve.ui.Command( 'indentation', 'increase' )
 );
 ve.ui.commandRegistry.register(
'outdent', new ve.ui.Command( 'indentation', 'decrease' )
 );
 ve.ui.commandRegistry.register(
-   'link', new ve.ui.Command( 'inspector', 'open', 'link' )
+   'code', new ve.ui.Command( 'annotation', 'toggle', 'textStyle/code' )
+);
+ve.ui.commandRegistry.register(
+   'strikethrough', new ve.ui.Command( 'annotation', 'toggle', 
'textStyle/strike' )
 );
 ve.ui.commandRegistry.register(
'language', new ve.ui.Command( 'inspector', 'open', 'language' )
-);
-ve.ui.commandRegistry.register(
-   'redo', new ve.ui.Command( 'history', 'redo' )
-);
-ve.ui.commandRegistry.register(
-   'undo', new ve.ui.Command( 'history', 'undo' )
 );
 ve.ui.commandRegistry.register(
'paragraph', new ve.ui.Command( 'format', 'convert', 'paragraph' )

-- 
To view, visit https://gerrit.wikimedia.org/r/98516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0fdf5f028f7191b0d662456ec1506490d7439a1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits