[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki/core)

2015-09-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove dead code
..


Remove dead code

Change-Id: Iafcb15a8843889bf7fbfb191b64d86e9f8561185
---
M includes/api/ApiQueryDeletedRevisions.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Anomie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/api/ApiQueryDeletedRevisions.php 
b/includes/api/ApiQueryDeletedRevisions.php
index bf48b19..fa1dfc2 100644
--- a/includes/api/ApiQueryDeletedRevisions.php
+++ b/includes/api/ApiQueryDeletedRevisions.php
@@ -46,7 +46,6 @@
);
}
 
-   $result = $this->getResult();
$pageSet = $this->getPageSet();
$pageMap = $pageSet->getGoodAndMissingTitlesByNamespace();
$pageCount = count( $pageSet->getGoodAndMissingTitles() );

-- 
To view, visit https://gerrit.wikimedia.org/r/240746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafcb15a8843889bf7fbfb191b64d86e9f8561185
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Anomie 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki/core)

2015-09-24 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/240746

Change subject: Remove dead code
..

Remove dead code

Change-Id: Iafcb15a8843889bf7fbfb191b64d86e9f8561185
---
M includes/api/ApiQueryDeletedRevisions.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/46/240746/1

diff --git a/includes/api/ApiQueryDeletedRevisions.php 
b/includes/api/ApiQueryDeletedRevisions.php
index bf48b19..fa1dfc2 100644
--- a/includes/api/ApiQueryDeletedRevisions.php
+++ b/includes/api/ApiQueryDeletedRevisions.php
@@ -46,7 +46,6 @@
);
}
 
-   $result = $this->getResult();
$pageSet = $this->getPageSet();
$pageMap = $pageSet->getGoodAndMissingTitlesByNamespace();
$pageCount = count( $pageSet->getGoodAndMissingTitles() );

-- 
To view, visit https://gerrit.wikimedia.org/r/240746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafcb15a8843889bf7fbfb191b64d86e9f8561185
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki/core)

2013-09-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove dead code
..


Remove dead code

Accidentally left in dabbbc7d2a88ceb9efce5742af05e848dbcaa66e

Change-Id: I58e65ca7ad23d00992f66f3bcee879e662b62ef0
---
M includes/OutputPage.php
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Parent5446: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 83a7d3f..bf9f5ac 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -2432,14 +2432,6 @@
 * @param $options Options array to pass to Linker
 */
public function addReturnTo( $title, $query = array(), $text = null, 
$options = array() ) {
-   if ( in_array( 'http', $options ) ) {
-   $proto = PROTO_HTTP;
-   } elseif ( in_array( 'https', $options ) ) {
-   $proto = PROTO_HTTPS;
-   } else {
-   $proto = PROTO_RELATIVE;
-   }
-
$link = $this-msg( 'returnto' )-rawParams(
Linker::link( $title, $text, array(), $query, $options 
) )-escaped();
$this-addHTML( p id=\mw-returnto\{$link}/p\n );

-- 
To view, visit https://gerrit.wikimedia.org/r/82080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I58e65ca7ad23d00992f66f3bcee879e662b62ef0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org
Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com
Gerrit-Reviewer: Parent5446 tylerro...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki/core)

2013-08-31 Thread Mattflaschen (Code Review) 
Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/82080


Change subject: Remove dead code
..

Remove dead code

Accidentally left in dabbbc7d2a88ceb9efce5742af05e848dbcaa66e

Change-Id: I58e65ca7ad23d00992f66f3bcee879e662b62ef0
---
M includes/OutputPage.php
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/80/82080/1

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 83a7d3f..bf9f5ac 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -2432,14 +2432,6 @@
 * @param $options Options array to pass to Linker
 */
public function addReturnTo( $title, $query = array(), $text = null, 
$options = array() ) {
-   if ( in_array( 'http', $options ) ) {
-   $proto = PROTO_HTTP;
-   } elseif ( in_array( 'https', $options ) ) {
-   $proto = PROTO_HTTPS;
-   } else {
-   $proto = PROTO_RELATIVE;
-   }
-
$link = $this-msg( 'returnto' )-rawParams(
Linker::link( $title, $text, array(), $query, $options 
) )-escaped();
$this-addHTML( p id=\mw-returnto\{$link}/p\n );

-- 
To view, visit https://gerrit.wikimedia.org/r/82080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58e65ca7ad23d00992f66f3bcee879e662b62ef0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen mflasc...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead code. - change (mediawiki/core)

2013-02-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove dead code.
..


Remove dead code.

$initialTime was never used. It was probably a clever trick
for an old time where ProfilerSimple used globals.

Change-Id: I34fd952127914d50ce4d12b6f9275926496aff9d
---
M maintenance/fileOpPerfTest.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  IAlex: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/fileOpPerfTest.php b/maintenance/fileOpPerfTest.php
index 4cb5e10..008d768 100644
--- a/maintenance/fileOpPerfTest.php
+++ b/maintenance/fileOpPerfTest.php
@@ -21,7 +21,6 @@
  * @ingroup Maintenance
  */
 
-$initialTime = microtime( true );
 $wgProfiler = array( 'class' = 'ProfilerSimpleText' );
 error_reporting( E_ALL );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/50124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34fd952127914d50ce4d12b6f9275926496aff9d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides platoni...@gmail.com
Gerrit-Reviewer: Demon ch...@wikimedia.org
Gerrit-Reviewer: IAlex ialex.w...@gmail.com
Gerrit-Reviewer: Krinkle ttij...@wikimedia.org
Gerrit-Reviewer: Platonides platoni...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove dead code. - change (mediawiki/core)

2013-02-20 Thread Platonides (Code Review) 
Platonides has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/50124


Change subject: Remove dead code.
..

Remove dead code.

$initialTime was never used. It was probably a clever trick
for an old time where ProfilerSimple used globals.

Change-Id: I34fd952127914d50ce4d12b6f9275926496aff9d
---
M maintenance/fileOpPerfTest.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/24/50124/1

diff --git a/maintenance/fileOpPerfTest.php b/maintenance/fileOpPerfTest.php
index 4cb5e10..008d768 100644
--- a/maintenance/fileOpPerfTest.php
+++ b/maintenance/fileOpPerfTest.php
@@ -21,7 +21,6 @@
  * @ingroup Maintenance
  */
 
-$initialTime = microtime( true );
 $wgProfiler = array( 'class' = 'ProfilerSimpleText' );
 error_reporting( E_ALL );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/50124
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I34fd952127914d50ce4d12b6f9275926496aff9d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides platoni...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits