[MediaWiki-commits] [Gerrit] Remove outdated fixme/todo in CoreParserFunctions.php - change (mediawiki/core)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/108316 Change subject: Remove outdated fixme/todo in CoreParserFunctions.php .. Remove outdated fixme/todo in CoreParserFunctions.php Title::getLength is not used and documentation of parameter is there Change-Id: I50679ff19695a3afedd556e242f27e4172a9774a --- M includes/parser/CoreParserFunctions.php 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/16/108316/1 diff --git a/includes/parser/CoreParserFunctions.php b/includes/parser/CoreParserFunctions.php index 35e8bf8..1cc7a18 100644 --- a/includes/parser/CoreParserFunctions.php +++ b/includes/parser/CoreParserFunctions.php @@ -679,12 +679,6 @@ * Return the size of the given page, or 0 if it's nonexistent. This is an * expensive parser function and can't be called too many times per page. * -* @todo FIXME: Title::getLength() documentation claims that it adds things -* to the link cache, so the local cache here should be unnecessary, but -* in fact calling getLength() repeatedly for the same $page does seem to -* run one query for each call? -* @todo Document parameters -* * @param $parser Parser * @param $page String Name of page to check (Default: empty string) * @param $raw String Should number be human readable with commas or just number -- To view, visit https://gerrit.wikimedia.org/r/108316 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I50679ff19695a3afedd556e242f27e4172a9774a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove outdated fixme/todo in CoreParserFunctions.php - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Remove outdated fixme/todo in CoreParserFunctions.php .. Remove outdated fixme/todo in CoreParserFunctions.php Title::getLength is not used and documentation of parameter is there Change-Id: I50679ff19695a3afedd556e242f27e4172a9774a --- M includes/parser/CoreParserFunctions.php 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Parent5446: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/parser/CoreParserFunctions.php b/includes/parser/CoreParserFunctions.php index 35e8bf8..1cc7a18 100644 --- a/includes/parser/CoreParserFunctions.php +++ b/includes/parser/CoreParserFunctions.php @@ -679,12 +679,6 @@ * Return the size of the given page, or 0 if it's nonexistent. This is an * expensive parser function and can't be called too many times per page. * -* @todo FIXME: Title::getLength() documentation claims that it adds things -* to the link cache, so the local cache here should be unnecessary, but -* in fact calling getLength() repeatedly for the same $page does seem to -* run one query for each call? -* @todo Document parameters -* * @param $parser Parser * @param $page String Name of page to check (Default: empty string) * @param $raw String Should number be human readable with commas or just number -- To view, visit https://gerrit.wikimedia.org/r/108316 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50679ff19695a3afedd556e242f27e4172a9774a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: Cscott canan...@wikimedia.org Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com Gerrit-Reviewer: Parent5446 tylerro...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
