[MediaWiki-commits] [Gerrit] Remove set focus to page - change (mediawiki...Wikibase)

2015-07-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove set focus to page
..


Remove set focus to page

Removed set focus to page after selecting site, because if tab key is
used for selecting the focus is set wrong.

Bug: T107063
Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
index e7789e8..fd7d0fb 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
@@ -300,8 +300,7 @@
$pageNameInput
.attr( 'lang', site.getLanguageCode() )
.attr( 'dir', site.getLanguageDirection() )
-   .show()
-   .focus();
+   .show();
} else {
$pageNameInput.hide();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/227666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) jonas.kr...@wikimedia.de
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove set focus to page - change (mediawiki...Wikibase)

2015-07-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove set focus to page
..


Remove set focus to page

Removed set focus to page after selecting site, because if tab key is
used for selecting the focus is set wrong.

Bug: T107063
Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
index e7789e8..fd7d0fb 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
@@ -300,8 +300,7 @@
$pageNameInput
.attr( 'lang', site.getLanguageCode() )
.attr( 'dir', site.getLanguageDirection() )
-   .show()
-   .focus();
+   .show();
} else {
$pageNameInput.hide();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/227750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.26wmf16
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Aude aude.w...@gmail.com
Gerrit-Reviewer: Jonas Kress (WMDE) jonas.kr...@wikimedia.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove set focus to page - change (mediawiki...Wikibase)

2015-07-29 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227750

Change subject: Remove set focus to page
..

Remove set focus to page

Removed set focus to page after selecting site, because if tab key is
used for selecting the focus is set wrong.

Bug: T107063
Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/50/227750/1

diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
index e7789e8..fd7d0fb 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
@@ -300,8 +300,7 @@
$pageNameInput
.attr( 'lang', site.getLanguageCode() )
.attr( 'dir', site.getLanguageDirection() )
-   .show()
-   .focus();
+   .show();
} else {
$pageNameInput.hide();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/227750
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.26wmf16
Gerrit-Owner: Aude aude.w...@gmail.com
Gerrit-Reviewer: Jonas Kress (WMDE) jonas.kr...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove set focus to page - change (mediawiki...Wikibase)

2015-07-29 Thread Jonas Kress (WMDE) (Code Review) 
Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227666

Change subject: Remove set focus to page
..

Remove set focus to page

Removed set focus to page after selecting site, because if tab key is
used for selecting the focus is set wrong.

Bug: T107063
Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/66/227666/1

diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js 
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
index e7789e8..fd7d0fb 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
@@ -300,8 +300,7 @@
$pageNameInput
.attr( 'lang', site.getLanguageCode() )
.attr( 'dir', site.getLanguageDirection() )
-   .show()
-   .focus();
+   .show();
} else {
$pageNameInput.hide();
}

-- 
To view, visit https://gerrit.wikimedia.org/r/227666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8eb4667fa1a5834259ee774e181e610b4439566a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) jonas.kr...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits