[MediaWiki-commits] [Gerrit] Remove support for getLastDiff from non-tux editor - change (mediawiki...Translate)
jenkins-bot has submitted this change and it was merged.
Change subject: Remove support for getLastDiff from non-tux editor
..
Remove support for getLastDiff from non-tux editor
Change-Id: I0b5774799a66e335c8b34b3d1ff06bcd83223145
---
M i18n/core/en.json
M resources/css/ext.translate.quickedit.css
M utils/TranslationHelpers.php
3 files changed, 0 insertions(+), 73 deletions(-)
Approvals:
Amire80: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/core/en.json b/i18n/core/en.json
index 45cda36..e9601b2 100644
--- a/i18n/core/en.json
+++ b/i18n/core/en.json
@@ -292,10 +292,6 @@
translate-dynagroup-recent-desc: This message group shows all recent
translations into this language.\nMost useful for the review tasks.,
translate-dynagroup-additions-label: Recent additions,
translate-dynagroup-additions-desc: This message group shows new and
changed messages.,
- translate-dynagroup-by: Translation made by {{GENDER:$1|$1}},
- translate-dynagroup-byc: Translation made by {{GENDER:$1|$1}} ($2),
- translate-dynagroup-last: Latest change by {{GENDER:$1|$1}},
- translate-dynagroup-lastc: Latest change by {{GENDER:$1|$1}} ($2),
translate-gethelp: Help,
translate-msggroupselector-projects: Message group,
translate-msggroupselector-search-placeholder: Search groups,
diff --git a/resources/css/ext.translate.quickedit.css
b/resources/css/ext.translate.quickedit.css
index fa117c5..aaeeeb6 100644
--- a/resources/css/ext.translate.quickedit.css
+++ b/resources/css/ext.translate.quickedit.css
@@ -124,10 +124,6 @@
background-color: #FFDBDB;
}
-.mw-sp-translate-latestchange {
- padding-bottom: 0;
-}
-
.tqe-fakeheader {
border: 1px solid #CCC;
padding: .75em;
diff --git a/utils/TranslationHelpers.php b/utils/TranslationHelpers.php
index 1ddd3fb..0558398 100644
--- a/utils/TranslationHelpers.php
+++ b/utils/TranslationHelpers.php
@@ -183,10 +183,6 @@
return (string)$this-callBox( 'check', $all['check'] );
}
- if ( $this-group instanceof RecentMessageGroup ) {
- $all['last-diff'] = array( $this, 'getLastDiff' );
- }
-
$boxes = array();
foreach ( $all as $type = $cb ) {
$box = $this-callBox( $type, $cb );
@@ -577,67 +573,6 @@
return $diff-getDiff(
wfMessage( 'tpt-diff-old' )-escaped(),
wfMessage( 'tpt-diff-new' )-escaped()
- );
- }
-
- protected function getLastDiff() {
- // Shortcuts
- $title = $this-handle-getTitle();
- $latestRevId = $title-getLatestRevID();
- $previousRevId = $title-getPreviousRevisionID( $latestRevId );
-
- $latestRev = Revision::newFromTitle( $title, $latestRevId );
- $previousRev = Revision::newFromTitle( $title, $previousRevId );
-
- $diffText = '';
-
- if ( $latestRev $previousRev ) {
- $latest = ContentHandler::getContentText(
$latestRev-getContent() );
- $previous = ContentHandler::getContentText(
$previousRev-getContent() );
-
- if ( $previous !== $latest ) {
- $diff = new DifferenceEngine;
-
- if ( method_exists( 'DifferenceEngine',
'setTextLanguage' ) ) {
- $diff-setTextLanguage(
$this-getTargetLanguage() );
- }
-
- $oldContent = ContentHandler::makeContent(
$previous, $diff-getTitle() );
- $newContent = ContentHandler::makeContent(
$latest, $diff-getTitle() );
-
- $diff-setContent( $oldContent, $newContent );
- $diff-setReducedLineNumbers();
- $diff-showDiffStyle();
- $diffText = $diff-getDiff( false, false );
- }
- }
-
- if ( !$latestRev ) {
- return null;
- }
-
- $context = RequestContext::getMain();
- $user = $latestRev-getUserText( Revision::FOR_THIS_USER,
$context-getUser() );
- $comment = $latestRev-getComment();
-
- if ( $diffText === '' ) {
- if ( strval( $comment ) !== '' ) {
- $text = $context-msg(
'translate-dynagroup-byc', $user, $comment )-escaped();
- } else {
- $text = $context-msg(
'translate-dynagroup-by', $user )-escaped();
- }
- } else {
- if ( strval(
[MediaWiki-commits] [Gerrit] Remove support for getLastDiff from non-tux editor - change (mediawiki...Translate)
Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/225543
Change subject: Remove support for getLastDiff from non-tux editor
..
Remove support for getLastDiff from non-tux editor
Change-Id: I0b5774799a66e335c8b34b3d1ff06bcd83223145
---
M i18n/core/en.json
M resources/css/ext.translate.quickedit.css
M utils/TranslationHelpers.php
3 files changed, 0 insertions(+), 73 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/43/225543/1
diff --git a/i18n/core/en.json b/i18n/core/en.json
index 45cda36..e9601b2 100644
--- a/i18n/core/en.json
+++ b/i18n/core/en.json
@@ -292,10 +292,6 @@
translate-dynagroup-recent-desc: This message group shows all recent
translations into this language.\nMost useful for the review tasks.,
translate-dynagroup-additions-label: Recent additions,
translate-dynagroup-additions-desc: This message group shows new and
changed messages.,
- translate-dynagroup-by: Translation made by {{GENDER:$1|$1}},
- translate-dynagroup-byc: Translation made by {{GENDER:$1|$1}} ($2),
- translate-dynagroup-last: Latest change by {{GENDER:$1|$1}},
- translate-dynagroup-lastc: Latest change by {{GENDER:$1|$1}} ($2),
translate-gethelp: Help,
translate-msggroupselector-projects: Message group,
translate-msggroupselector-search-placeholder: Search groups,
diff --git a/resources/css/ext.translate.quickedit.css
b/resources/css/ext.translate.quickedit.css
index fa117c5..aaeeeb6 100644
--- a/resources/css/ext.translate.quickedit.css
+++ b/resources/css/ext.translate.quickedit.css
@@ -124,10 +124,6 @@
background-color: #FFDBDB;
}
-.mw-sp-translate-latestchange {
- padding-bottom: 0;
-}
-
.tqe-fakeheader {
border: 1px solid #CCC;
padding: .75em;
diff --git a/utils/TranslationHelpers.php b/utils/TranslationHelpers.php
index 1ddd3fb..0558398 100644
--- a/utils/TranslationHelpers.php
+++ b/utils/TranslationHelpers.php
@@ -183,10 +183,6 @@
return (string)$this-callBox( 'check', $all['check'] );
}
- if ( $this-group instanceof RecentMessageGroup ) {
- $all['last-diff'] = array( $this, 'getLastDiff' );
- }
-
$boxes = array();
foreach ( $all as $type = $cb ) {
$box = $this-callBox( $type, $cb );
@@ -577,67 +573,6 @@
return $diff-getDiff(
wfMessage( 'tpt-diff-old' )-escaped(),
wfMessage( 'tpt-diff-new' )-escaped()
- );
- }
-
- protected function getLastDiff() {
- // Shortcuts
- $title = $this-handle-getTitle();
- $latestRevId = $title-getLatestRevID();
- $previousRevId = $title-getPreviousRevisionID( $latestRevId );
-
- $latestRev = Revision::newFromTitle( $title, $latestRevId );
- $previousRev = Revision::newFromTitle( $title, $previousRevId );
-
- $diffText = '';
-
- if ( $latestRev $previousRev ) {
- $latest = ContentHandler::getContentText(
$latestRev-getContent() );
- $previous = ContentHandler::getContentText(
$previousRev-getContent() );
-
- if ( $previous !== $latest ) {
- $diff = new DifferenceEngine;
-
- if ( method_exists( 'DifferenceEngine',
'setTextLanguage' ) ) {
- $diff-setTextLanguage(
$this-getTargetLanguage() );
- }
-
- $oldContent = ContentHandler::makeContent(
$previous, $diff-getTitle() );
- $newContent = ContentHandler::makeContent(
$latest, $diff-getTitle() );
-
- $diff-setContent( $oldContent, $newContent );
- $diff-setReducedLineNumbers();
- $diff-showDiffStyle();
- $diffText = $diff-getDiff( false, false );
- }
- }
-
- if ( !$latestRev ) {
- return null;
- }
-
- $context = RequestContext::getMain();
- $user = $latestRev-getUserText( Revision::FOR_THIS_USER,
$context-getUser() );
- $comment = $latestRev-getComment();
-
- if ( $diffText === '' ) {
- if ( strval( $comment ) !== '' ) {
- $text = $context-msg(
'translate-dynagroup-byc', $user, $comment )-escaped();
- } else {
- $text = $context-msg(
'translate-dynagroup-by', $user )-escaped();
- }
-
