[MediaWiki-commits] [Gerrit] Rename confusingly named function - change (mediawiki...UniversalLanguageSelector)

2013-04-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Rename confusingly named function
..


Rename confusingly named function

Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
---
M resources/js/ext.uls.inputsettings.js
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.uls.inputsettings.js 
b/resources/js/ext.uls.inputsettings.js
index d95e288..74e4e2a 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -71,7 +71,7 @@
this.name = $.i18n( 'ext-uls-input-settings-title-short' );
this.description = $.i18n( 'ext-uls-input-settings-desc' );
this.$template = $( template );
-   this.imeLanguage = this.getImeLanguage();
+   this.imeLanguage = this.getInterfaceLanguage();
this.contentLanguage = this.getContentLanguage();
this.$imes = null;
this.$parent = $parent;
@@ -376,8 +376,7 @@
 * Get the current user interface language.
 * @returns String Current UI language
 */
-   // XXX: Probably bad name
-   getImeLanguage: function () {
+   getInterfaceLanguage: function () {
return mw.config.get( 'wgUserLanguage' );
},
 

-- 
To view, visit https://gerrit.wikimedia.org/r/61361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Rename confusingly named function - change (mediawiki...UniversalLanguageSelector)

2013-04-29 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/61361


Change subject: Rename confusingly named function
..

Rename confusingly named function

Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
---
M resources/js/ext.uls.inputsettings.js
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/61/61361/1

diff --git a/resources/js/ext.uls.inputsettings.js 
b/resources/js/ext.uls.inputsettings.js
index d95e288..74e4e2a 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -71,7 +71,7 @@
this.name = $.i18n( 'ext-uls-input-settings-title-short' );
this.description = $.i18n( 'ext-uls-input-settings-desc' );
this.$template = $( template );
-   this.imeLanguage = this.getImeLanguage();
+   this.imeLanguage = this.getInterfaceLanguage();
this.contentLanguage = this.getContentLanguage();
this.$imes = null;
this.$parent = $parent;
@@ -376,8 +376,7 @@
 * Get the current user interface language.
 * @returns String Current UI language
 */
-   // XXX: Probably bad name
-   getImeLanguage: function () {
+   getInterfaceLanguage: function () {
return mw.config.get( 'wgUserLanguage' );
},
 

-- 
To view, visit https://gerrit.wikimedia.org/r/61361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I685a1658ec911e28cba4c9d3d7cbaaf4f1cca22e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits