[MediaWiki-commits] [Gerrit] Rename getTitle - change (mediawiki...MathSearch)

2015-12-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Rename getTitle
..


Rename getTitle

* getTitle overwrites the getTitle method of the parent class,
  which was not intended.

Change-Id: I7da6cacd311d4b0579ea68fa9b8a275c4bae7891
---
M includes/special/SpecialMlpEval.php
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Physikerwelt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/special/SpecialMlpEval.php 
b/includes/special/SpecialMlpEval.php
index 32183eb..b106969 100644
--- a/includes/special/SpecialMlpEval.php
+++ b/includes/special/SpecialMlpEval.php
@@ -332,7 +332,7 @@
/**
 * @return Title
 */
-   public function getTitle() {
+   public function getRevisionTitle() {
return $this->revision->getTitle();
}
 
@@ -524,7 +524,8 @@
}
 
private function getWikiTextLink() {
-   return 
"[[Special:Permalink/{$this->oldId}#{$this->fId}|{$this->getTitle()}#{$this->fId}]]";
+   $description = "{$this->getRevisionTitle()}#{$this->fId}";
+   return 
"[[Special:Permalink/{$this->oldId}#{$this->fId}|$description]]";
}
 
private function printFormulaRef() {
@@ -570,7 +571,7 @@
$popts->setInterfaceMessage( false );
 
$parserOutput = $wgParser->getFreshParser()->parse(
-   $hl->getWikiText(), $this->getTitle(), $popts 
)->getText();
+   $hl->getWikiText(), $this->getRevisionTitle(), $popts 
)->getText();
if ( $filter ){
call_user_func_array( $filter, array( &$parserOutput ) 
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/258125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7da6cacd311d4b0579ea68fa9b8a275c4bae7891
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 
Gerrit-Reviewer: Dyiop 
Gerrit-Reviewer: Hcohl 
Gerrit-Reviewer: Physikerwelt 
Gerrit-Reviewer: Whyameri 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Rename getTitle - change (mediawiki...MathSearch)

2015-12-10 Thread Physikerwelt (Code Review) 
Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/258125

Change subject: Rename getTitle
..

Rename getTitle

* getTitle overwrites the getTitle method of the parent class,
  which was not intended.

Change-Id: I7da6cacd311d4b0579ea68fa9b8a275c4bae7891
---
M includes/special/SpecialMlpEval.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch 
refs/changes/25/258125/1

diff --git a/includes/special/SpecialMlpEval.php 
b/includes/special/SpecialMlpEval.php
index 32183eb..eb7bded 100644
--- a/includes/special/SpecialMlpEval.php
+++ b/includes/special/SpecialMlpEval.php
@@ -332,7 +332,7 @@
/**
 * @return Title
 */
-   public function getTitle() {
+   public function getRevisionTitle() {
return $this->revision->getTitle();
}
 
@@ -524,7 +524,7 @@
}
 
private function getWikiTextLink() {
-   return 
"[[Special:Permalink/{$this->oldId}#{$this->fId}|{$this->getTitle()}#{$this->fId}]]";
+   return 
"[[Special:Permalink/{$this->oldId}#{$this->fId}|{$this->getRevisionTitle()}#{$this->fId}]]";
}
 
private function printFormulaRef() {
@@ -570,7 +570,7 @@
$popts->setInterfaceMessage( false );
 
$parserOutput = $wgParser->getFreshParser()->parse(
-   $hl->getWikiText(), $this->getTitle(), $popts 
)->getText();
+   $hl->getWikiText(), $this->getRevisionTitle(), $popts 
)->getText();
if ( $filter ){
call_user_func_array( $filter, array( &$parserOutput ) 
);
}

-- 
To view, visit https://gerrit.wikimedia.org/r/258125
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7da6cacd311d4b0579ea68fa9b8a275c4bae7891
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits