[MediaWiki-commits] [Gerrit] Renamed fingerprintview widgets - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Renamed fingerprintview widgets .. Renamed fingerprintview widgets fingerprintview widgets were named incorrectly. As Fingerprint is the aggregation of labels, descriptions and aliases in all languages, fingerprintview should have been what was labeled fingerprintgroupview. While there is no fictitious term for the aggregation of label, description and aliases of a single language and the term Fingerprint does not pursue a solid concept, the UI components have been renamed in a more obvious fashion. entitytermsview aggregates all term related objects of an entity. (Fingerprint is actually an aggregation of wikibase.datamodel.Term(Map) and wikibase.datamodel.MultiTerm(Map) objects.) This change advances the effort of renaming/removing the term Fingerprint. Bug: T75655 Change-Id: I084b6a11f8ddb7930b145e7852b7a5e66daa0a32 --- M lib/resources/Resources.php R lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.js R lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguageview.js A lib/resources/jquery.wikibase/jquery.wikibase.entitytermsview.js M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js D lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js M lib/resources/jquery.wikibase/resources.php A lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css A lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.css A lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css D lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintgroupview.css D lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintlistview.css D lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintview.css A lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.tests.js A lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsforlanguageview.tests.js A lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsview.tests.js D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js M lib/tests/qunit/jquery.wikibase/resources.php M repo/includes/View/TermBoxView.php M repo/resources/templates.php M repo/resources/wikibase.ui.entityViewInit.js 23 files changed, 1,234 insertions(+), 1,204 deletions(-) Approvals: Adrian Lang: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php index fd3e2ec..8b3739b 100644 --- a/lib/resources/Resources.php +++ b/lib/resources/Resources.php @@ -34,9 +34,9 @@ 'jquery.wikibase/themes/default/jquery.wikibase.aliasesview.css', 'jquery.wikibase/themes/default/jquery.wikibase.descriptionview.css', 'jquery.wikibase/themes/default/jquery.wikibase.entityview.css', - 'jquery.wikibase/themes/default/jquery.wikibase.fingerprintgroupview.css', - 'jquery.wikibase/themes/default/jquery.wikibase.fingerprintlistview.css', - 'jquery.wikibase/themes/default/jquery.wikibase.fingerprintview.css', + 'jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css', + 'jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css', + 'jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguageview.css', 'jquery.wikibase/themes/default/jquery.wikibase.labelview.css', 'jquery.wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.css', 'jquery.wikibase/themes/default/jquery.wikibase.sitelinkgroupview.css', diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintlistview.js b/lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.js similarity index 82% rename from lib/resources/jquery.wikibase/jquery.wikibase.fingerprintlistview.js rename to lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.js index 842162f..4373afc 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintlistview.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.js @@ -8,7 +8,7 @@ var PARENT = $.ui.TemplatedWidget; /** - * Displays multiple fingerprints (see jQuery.wikibase.fingerprintview). + * Displays multiple fingerprints (see jQuery.wikibase.entitytermsforlanguageview). * @since 0.5 *
[MediaWiki-commits] [Gerrit] Renamed fingerprintview widgets - change (mediawiki...Wikibase)
Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180438
Change subject: Renamed fingerprintview widgets
..
Renamed fingerprintview widgets
fingerprintview widgets were named incorrectly. As Fingerprint is the
aggregation of labels,
descriptions and aliases in all languages, fingerprintview should have been
what was
labeled fingerprintgroupview. While there is no fictitious term for the
aggregation of label,
description and aliases of a single language and the term Fingerprint does
not pursue a
solid concept, the UI components have been renamed in a more obvious fashion.
entitytermsview aggregates all term related objects of an entity.
(Fingerprint is actually
an aggregation of wikibase.datamodel.Term(Map) and
wikibase.datamodel.MultiTerm(Map) objects.)
This change advances the effort of renaming/removing the term Fingerprint.
-75655
Change-Id: I084b6a11f8ddb7930b145e7852b7a5e66daa0a32
---
M lib/resources/Resources.php
R lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguage.js
R
lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.js
A lib/resources/jquery.wikibase/jquery.wikibase.entitytermsview.js
M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
D lib/resources/jquery.wikibase/jquery.wikibase.fingerprintgroupview.js
M lib/resources/jquery.wikibase/resources.php
A
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguage.css
A
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css
A
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css
D
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintgroupview.css
D
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintlistview.css
D
lib/resources/jquery.wikibase/themes/default/jquery.wikibase.fingerprintview.css
A
lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsforlanguage.tests.js
A
lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsforlanguagelistview.tests.js
A lib/tests/qunit/jquery.wikibase/jquery.wikibase.entitytermsview.tests.js
D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintgroupview.tests.js
D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintlistview.tests.js
D lib/tests/qunit/jquery.wikibase/jquery.wikibase.fingerprintview.tests.js
M lib/tests/qunit/jquery.wikibase/resources.php
M repo/includes/View/TermBoxView.php
M repo/resources/templates.php
M repo/resources/wikibase.ui.entityViewInit.js
23 files changed, 1,226 insertions(+), 1,205 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/38/180438/1
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index fd3e2ec..610ef89 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -34,9 +34,9 @@
'jquery.wikibase/themes/default/jquery.wikibase.aliasesview.css',
'jquery.wikibase/themes/default/jquery.wikibase.descriptionview.css',
'jquery.wikibase/themes/default/jquery.wikibase.entityview.css',
-
'jquery.wikibase/themes/default/jquery.wikibase.fingerprintgroupview.css',
-
'jquery.wikibase/themes/default/jquery.wikibase.fingerprintlistview.css',
-
'jquery.wikibase/themes/default/jquery.wikibase.fingerprintview.css',
+
'jquery.wikibase/themes/default/jquery.wikibase.entitytermsview.css',
+
'jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguagelistview.css',
+
'jquery.wikibase/themes/default/jquery.wikibase.entitytermsforlanguage.css',
'jquery.wikibase/themes/default/jquery.wikibase.labelview.css',
'jquery.wikibase/themes/default/jquery.wikibase.sitelinkgrouplistview.css',
'jquery.wikibase/themes/default/jquery.wikibase.sitelinkgroupview.css',
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguage.js
similarity index 94%
rename from lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
rename to
lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguage.js
index 889bb40..435c96c 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.fingerprintview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entitytermsforlanguage.js
@@ -47,9 +47,9 @@
*- {jQuery.Event}
*- {Error|null}
*/
-$.widget( 'wikibase.fingerprintview', PARENT, {
+$.widget( 'wikibase.entitytermsforlanguage', PARENT, {
options: {
- template:
