[MediaWiki-commits] [Gerrit] Renamed zero fld to iszero (val=yes/no) - change (analytics/zero-sms)

2014-09-21 Thread Yurik (Code Review)
Yurik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/161808

Change subject: Renamed zero fld to iszero (val=yes/no)
..

Renamed zero fld to iszero (val=yes/no)

Change-Id: I233231e5043649a973d963b5a91d96159b9a0a4f
---
M scripts/weblogs.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/zero-sms 
refs/changes/08/161808/1

diff --git a/scripts/weblogs.py b/scripts/weblogs.py
index 3fbd90c..90522a4 100644
--- a/scripts/weblogs.py
+++ b/scripts/weblogs.py
@@ -22,7 +22,7 @@
 
 
 columnHeaders10 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,count'.split(',')
-columnHeaders11 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,zero,count'.split(',')
+columnHeaders11 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,iszero,count'.split(',')
 validSubDomains = {'m', 'zero', 'mobile', 'wap'}
 validHttpCode = {'200', '304'}
 
@@ -294,11 +294,11 @@
 for id in xcs:
 
 s = StringIO.StringIO()
-pivot_table(data[data.xcs == id], 'count', ['date', 'zero'], 
aggfunc=np.sum).to_csv(s, header=True)
+pivot_table(data[data.xcs == id], 'count', ['date', 'iszero'], 
aggfunc=np.sum).to_csv(s, header=True)
 result = s.getvalue()
 
-# sortColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'zero']
-# outColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'zero', 'count']
+# sortColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'iszero']
+# outColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'iszero', 'count']
 # xcsData = data[data.xcs == id].sort(columns=sortColumns)
 # result = 
xcsData.sort(columns=sortColumns).to_csv(columns=outColumns, index=False)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/161808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I233231e5043649a973d963b5a91d96159b9a0a4f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/zero-sms
Gerrit-Branch: master
Gerrit-Owner: Yurik yu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Renamed zero fld to iszero (val=yes/no) - change (analytics/zero-sms)

2014-09-21 Thread Yurik (Code Review)
Yurik has submitted this change and it was merged.

Change subject: Renamed zero fld to iszero (val=yes/no)
..


Renamed zero fld to iszero (val=yes/no)

Change-Id: I233231e5043649a973d963b5a91d96159b9a0a4f
---
M scripts/weblogs.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Yurik: Verified; Looks good to me, approved



diff --git a/scripts/weblogs.py b/scripts/weblogs.py
index 3fbd90c..90522a4 100644
--- a/scripts/weblogs.py
+++ b/scripts/weblogs.py
@@ -22,7 +22,7 @@
 
 
 columnHeaders10 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,count'.split(',')
-columnHeaders11 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,zero,count'.split(',')
+columnHeaders11 = 
u'date,type,xcs,via,ipset,https,lang,subdomain,site,iszero,count'.split(',')
 validSubDomains = {'m', 'zero', 'mobile', 'wap'}
 validHttpCode = {'200', '304'}
 
@@ -294,11 +294,11 @@
 for id in xcs:
 
 s = StringIO.StringIO()
-pivot_table(data[data.xcs == id], 'count', ['date', 'zero'], 
aggfunc=np.sum).to_csv(s, header=True)
+pivot_table(data[data.xcs == id], 'count', ['date', 'iszero'], 
aggfunc=np.sum).to_csv(s, header=True)
 result = s.getvalue()
 
-# sortColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'zero']
-# outColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'zero', 'count']
+# sortColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'iszero']
+# outColumns = ['date', 'via', 'ipset', 'https', 'lang', 
'subdomain', 'site', 'iszero', 'count']
 # xcsData = data[data.xcs == id].sort(columns=sortColumns)
 # result = 
xcsData.sort(columns=sortColumns).to_csv(columns=outColumns, index=False)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/161808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I233231e5043649a973d963b5a91d96159b9a0a4f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/zero-sms
Gerrit-Branch: master
Gerrit-Owner: Yurik yu...@wikimedia.org
Gerrit-Reviewer: Yurik yu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits