[MediaWiki-commits] [Gerrit] Replace in-line style for error class in warnings - change (mediawiki...Renameuser)
jenkins-bot has submitted this change and it was merged. Change subject: Replace in-line style for error class in warnings .. Replace in-line style for error class in warnings This commit replaces the in-line, hard-coded style used when representing warnings when renaming users with the shared .error CSS class. This makes it easier for end-users to modify the look of the messages, and ensures a uniform style across MediaWiki. The previous hard-coded style is bright red and bold, whereas the error class is a darker shade of red, and larger instead of bold. Change-Id: I8ecc9eb4b023b036e86ef802e69be51490ef86f0 --- M specials/SpecialRenameuser.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified diff --git a/specials/SpecialRenameuser.php b/specials/SpecialRenameuser.php index 42aef35..2ed5219 100644 --- a/specials/SpecialRenameuser.php +++ b/specials/SpecialRenameuser.php @@ -149,7 +149,7 @@ " . $this->msg( 'renameuserwarnings' )->escaped() . " " . - '' . + '' . implode( '', $warningsHtml ) . '' . ' ' -- To view, visit https://gerrit.wikimedia.org/r/271315 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ecc9eb4b023b036e86ef802e69be51490ef86f0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Renameuser Gerrit-Branch: master Gerrit-Owner: Microchip08Gerrit-Reviewer: Aaron Schulz Gerrit-Reviewer: Legoktm Gerrit-Reviewer: Siebrand Gerrit-Reviewer: Umherirrender Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Replace in-line style for error class in warnings - change (mediawiki...Renameuser)
Microchip08 has uploaded a new change for review. https://gerrit.wikimedia.org/r/271315 Change subject: Replace in-line style for error class in warnings .. Replace in-line style for error class in warnings This commit replaces the in-line, hard-coded style used when representing warnings when renaming users with the shared .error CSS class. This makes it easier for end-users to modify the look of the messages, and ensures a uniform style across MediaWiki. The previous hard-coded style is bright red and bold, whereas the error class is a darker shade of red, and larger instead of bold. Change-Id: I8ecc9eb4b023b036e86ef802e69be51490ef86f0 --- M specials/SpecialRenameuser.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Renameuser refs/changes/15/271315/1 diff --git a/specials/SpecialRenameuser.php b/specials/SpecialRenameuser.php index 42aef35..2ed5219 100644 --- a/specials/SpecialRenameuser.php +++ b/specials/SpecialRenameuser.php @@ -149,7 +149,7 @@ " . $this->msg( 'renameuserwarnings' )->escaped() . " " . - '' . + '' . implode( '', $warningsHtml ) . '' . ' ' -- To view, visit https://gerrit.wikimedia.org/r/271315 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ecc9eb4b023b036e86ef802e69be51490ef86f0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Renameuser Gerrit-Branch: master Gerrit-Owner: Microchip08___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits