[MediaWiki-commits] [Gerrit] Require bs4 for IndexPage BasePage tests - change (pywikibot/core)

2015-10-04 Thread John Vandenberg (Code Review) 
John Vandenberg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243598

Change subject: Require bs4 for IndexPage BasePage tests
..

Require bs4 for IndexPage BasePage tests

458dd0ac introduced tests for BasePage methods to IndexPage,
however these tests can only be run when bs4 is available.

Change-Id: Ief32075086d36368082283ded8c87cd0e4c0a891
---
M tests/proofreadpage_tests.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/98/243598/1

diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 45ad5fc..03ef7d0 100644
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -270,7 +270,7 @@
 self.assertEqual(page.namespace(), source.namespace)
 
 
-class TestBasePageMethodsIndexPage(BasePageMethodsTestBase):
+class TestBasePageMethodsIndexPage(IndexPageTestCase, BasePageMethodsTestBase):
 
 """Test behavior of ProofreadPage methods inherited from BasePage."""
 
@@ -289,7 +289,8 @@
 self._test_return_datatypes()
 
 
-class TestLoadRevisionsCachingIndexPage(BasePageLoadRevisionsCachingTestBase):
+class TestLoadRevisionsCachingIndexPage(IndexPageTestCase,
+BasePageLoadRevisionsCachingTestBase):
 
 """Test site.loadrevisions() caching."""
 

-- 
To view, visit https://gerrit.wikimedia.org/r/243598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief32075086d36368082283ded8c87cd0e4c0a891
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Require bs4 for IndexPage BasePage tests - change (pywikibot/core)

2015-10-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Require bs4 for IndexPage BasePage tests
..


Require bs4 for IndexPage BasePage tests

458dd0ac introduced tests for BasePage methods to IndexPage,
however these tests can only be run when bs4 is available.

Change-Id: Ief32075086d36368082283ded8c87cd0e4c0a891
---
M tests/proofreadpage_tests.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 45ad5fc..03ef7d0 100644
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -270,7 +270,7 @@
 self.assertEqual(page.namespace(), source.namespace)
 
 
-class TestBasePageMethodsIndexPage(BasePageMethodsTestBase):
+class TestBasePageMethodsIndexPage(IndexPageTestCase, BasePageMethodsTestBase):
 
 """Test behavior of ProofreadPage methods inherited from BasePage."""
 
@@ -289,7 +289,8 @@
 self._test_return_datatypes()
 
 
-class TestLoadRevisionsCachingIndexPage(BasePageLoadRevisionsCachingTestBase):
+class TestLoadRevisionsCachingIndexPage(IndexPageTestCase,
+BasePageLoadRevisionsCachingTestBase):
 
 """Test site.loadrevisions() caching."""
 

-- 
To view, visit https://gerrit.wikimedia.org/r/243598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief32075086d36368082283ded8c87cd0e4c0a891
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: XZise 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits