[MediaWiki-commits] [Gerrit] Separate dataset status between checked ok and unchecked ok - change (analytics/refinery)
Ottomata has submitted this change and it was merged. Change subject: Separate dataset status between checked ok and unchecked ok .. Separate dataset status between checked ok and unchecked ok For raw webrequest tables, there are automated checks before we mark a partition as ok. We add a separate status to dustinguish those two kinds of marking ok. Change-Id: I9ebb52f4f919416a05c5989bc7dd7a0740f60389 --- M bin/refinery-dump-status-webrequest-partitions 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved diff --git a/bin/refinery-dump-status-webrequest-partitions b/bin/refinery-dump-status-webrequest-partitions index 150b045..2f2c123 100755 --- a/bin/refinery-dump-status-webrequest-partitions +++ b/bin/refinery-dump-status-webrequest-partitions @@ -345,7 +345,7 @@ local FILE_ABS=$ARCHIVE_DATA_DIR_ABS/webrequest/$BASE$SUFFIX if [ -e $FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS | done @@ -370,7 +370,7 @@ if [ -e $FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS } @@ -442,7 +442,7 @@ SUCCESS_FILE_ABS=$WEBREQUEST_DATA_DIR_ABS/webrequest_source=$SOURCE/$DATE_DIRS_REL/_SUCCESS if [ -e $SUCCESS_FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS | done @@ -523,7 +523,8 @@ Statuses: - . -- Dataset entry is present (does not imply quality guarantees) + . -- Dataset entry passed automated checks + _ -- Dataset entry is present (does not imply quality guarantees) M -- Dataset entry manually marked ok X -- Dataset entry is known to not be ok -- To view, visit https://gerrit.wikimedia.org/r/188008 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ebb52f4f919416a05c5989bc7dd7a0740f60389 Gerrit-PatchSet: 3 Gerrit-Project: analytics/refinery Gerrit-Branch: master Gerrit-Owner: QChris christ...@quelltextlich.at Gerrit-Reviewer: Ottomata o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Separate dataset status between checked ok and unchecked ok - change (analytics/refinery)
Hello Ottomata, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/188008 to review the following change. Change subject: Separate dataset status between checked ok and unchecked ok .. Separate dataset status between checked ok and unchecked ok For raw webrequest tables, there are automated checks before we mark a partition as ok. We add a separate status to dustinguish those two kinds of marking ok. Change-Id: I9ebb52f4f919416a05c5989bc7dd7a0740f60389 --- M bin/refinery-dump-status-webrequest-partitions 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery refs/changes/08/188008/1 diff --git a/bin/refinery-dump-status-webrequest-partitions b/bin/refinery-dump-status-webrequest-partitions index 05ac934..7dd7d17 100755 --- a/bin/refinery-dump-status-webrequest-partitions +++ b/bin/refinery-dump-status-webrequest-partitions @@ -346,7 +346,7 @@ FILE_ABS=$ARCHIVE_DATA_DIR_ABS/webrequest/$BASE$SUFFIX if [ -e $FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS | done @@ -371,7 +371,7 @@ if [ -e $FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS } @@ -443,7 +443,7 @@ SUCCESS_FILE_ABS=$WEBREQUEST_DATA_DIR_ABS/webrequest_source=$SOURCE/$DATE_DIRS_REL/_SUCCESS if [ -e $SUCCESS_FILE_ABS ] then -STATUS=. +STATUS=_ fi log_no_lf $STATUS | done @@ -524,7 +524,8 @@ Statuses: - . -- Dataset entry is present (does not imply quality guarantees) + . -- Dataset entry passed automated checks + _ -- Dataset entry is present (does not imply quality guarantees) M -- Dataset entry manually marked ok X -- Dataset entry is known to not be ok -- To view, visit https://gerrit.wikimedia.org/r/188008 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ebb52f4f919416a05c5989bc7dd7a0740f60389 Gerrit-PatchSet: 1 Gerrit-Project: analytics/refinery Gerrit-Branch: master Gerrit-Owner: QChris christ...@quelltextlich.at Gerrit-Reviewer: Ottomata o...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
