[MediaWiki-commits] [Gerrit] Set mwparserfromhell as optional on all platforms - change (pywikibot/core)

2015-05-29 Thread XZise (Code Review) 
XZise has submitted this change and it was merged.

Change subject: Set mwparserfromhell as optional on all platforms
..


Set mwparserfromhell as optional on all platforms

Potential users are writing their own library instead
of using pywikibot because it has mandatory dependencies
that they do not want, such as mwparserfromhell.

Bug: T78378
Change-Id: I9daf480996ca6f9d2f0deff492c968bdd200
---
M setup.py
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  John Vandenberg: Looks good to me, but someone else must approve
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/setup.py b/setup.py
index f73d061..5498742 100644
--- a/setup.py
+++ b/setup.py
@@ -98,11 +98,6 @@
 print("ERROR: Python 3.3 or higher is required!")
 sys.exit(1)
 
-if os.name != 'nt':
-# See bug 66010, Windows users will have issues
-# when trying to build the C modules.
-dependencies += extra_deps['mwparserfromhell']
-
 # Some of the ui_tests depend on accessing the console window's menu
 # to set the console font and copy and paste, achieved using pywinauto
 # which depends on pywin32.

-- 
To view, visit https://gerrit.wikimedia.org/r/213480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9daf480996ca6f9d2f0deff492c968bdd200
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: XZise 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Set mwparserfromhell as optional on all platforms - change (pywikibot/core)

2015-05-24 Thread John Vandenberg (Code Review) 
John Vandenberg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213480

Change subject: Set mwparserfromhell as optional on all platforms
..

Set mwparserfromhell as optional on all platforms

Potential users are writing their own library instead
of using pywikibot because it has mandatory dependencies
that they do not want, such as mwparserfromhell.

Bug: T78378
Change-Id: I9daf480996ca6f9d2f0deff492c968bdd200
---
M setup.py
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/80/213480/1

diff --git a/setup.py b/setup.py
index 0691588..248141f 100644
--- a/setup.py
+++ b/setup.py
@@ -98,11 +98,6 @@
 print("ERROR: Python 3.3 or higher is required!")
 sys.exit(1)
 
-if os.name != 'nt':
-# See bug 66010, Windows users will have issues
-# when trying to build the C modules.
-dependencies += extra_deps['mwparserfromhell']
-
 # Some of the ui_tests depend on accessing the console window's menu
 # to set the console font and copy and paste, achieved using pywinauto
 # which depends on pywin32.

-- 
To view, visit https://gerrit.wikimedia.org/r/213480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9daf480996ca6f9d2f0deff492c968bdd200
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits