[MediaWiki-commits] [Gerrit] Skin::commonPrintStylesheet() was removed - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged.
Change subject: Skin::commonPrintStylesheet() was removed
..
Skin::commonPrintStylesheet() was removed
Deprecated since 1.22. Removed from only use in Gerrit extension
ThemeDesigner.
Change-Id: Ib6d72eff90f4ffef69274db364157b416455f17d
---
M RELEASE-NOTES-1.27
M includes/skins/Skin.php
2 files changed, 2 insertions(+), 16 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index 2a30b3d..97938e2 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -391,6 +391,8 @@
* UserrightsPage::makeGroupNameListForLog() was removed (deprecated since
1.21).
* MediaWikiSite::newFromGlobalId() was removed (deprecated since 1.21).
* Title::newFromRedirect() was removed (deprecated since 1.21).
+* Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
+
== Compatibility ==
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 2918cbe..63b6978 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -1360,22 +1360,6 @@
}
/**
-* This function previously controlled whether the
'mediawiki.legacy.wikiprintable' module
-* should be loaded by OutputPage. That module no longer exists and the
return value of this
-* method is ignored.
-*
-* If your skin doesn't provide its own print styles, the
'mediawiki.legacy.commonPrint' module
-* can be used instead (SkinTemplate-based skins do it automatically).
-*
-* @deprecated since 1.22
-* @return bool
-*/
- public function commonPrintStylesheet() {
- wfDeprecated( __METHOD__, '1.22' );
- return false;
- }
-
- /**
* Gets new talk page messages for the current user and returns an
* appropriate alert message (or an empty string if there are no
messages)
* @return string
--
To view, visit https://gerrit.wikimedia.org/r/276055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6d72eff90f4ffef69274db364157b416455f17d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand
Gerrit-Reviewer: Jack Phoenix
Gerrit-Reviewer: Krinkle
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Skin::commonPrintStylesheet() was removed - change (mediawiki/core)
Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276055
Change subject: Skin::commonPrintStylesheet() was removed
..
Skin::commonPrintStylesheet() was removed
Deprecated since 1.22. Removed from only use in Gerrit extension
ThemeDesigner.
Change-Id: Ib6d72eff90f4ffef69274db364157b416455f17d
---
M RELEASE-NOTES-1.27
M includes/skins/Skin.php
2 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/55/276055/1
diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index 9da54d2..c816ce1 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -240,6 +240,7 @@
* OutputPage::getScript() was removed (deprecated since 1.24).
* OutputPage::out() was removed (deprecated since 1.22).
* OutputPage::setAllowedModules() was removed (deprecated since 1.24).
+* Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
* UserrightsPage::makeGroupNameListForLog() was removed (deprecated since
1.21).
=== Languages updated in 1.27 ===
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index b80788b..232c0c9 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -1358,22 +1358,6 @@
}
/**
-* This function previously controlled whether the
'mediawiki.legacy.wikiprintable' module
-* should be loaded by OutputPage. That module no longer exists and the
return value of this
-* method is ignored.
-*
-* If your skin doesn't provide its own print styles, the
'mediawiki.legacy.commonPrint' module
-* can be used instead (SkinTemplate-based skins do it automatically).
-*
-* @deprecated since 1.22
-* @return bool
-*/
- public function commonPrintStylesheet() {
- wfDeprecated( __METHOD__, '1.22' );
- return false;
- }
-
- /**
* Gets new talk page messages for the current user and returns an
* appropriate alert message (or an empty string if there are no
messages)
* @return string
--
To view, visit https://gerrit.wikimedia.org/r/276055
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6d72eff90f4ffef69274db364157b416455f17d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
