[MediaWiki-commits] [Gerrit] Skin::getCommonStylePath() was removed - change (mediawiki/core)

2016-04-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Skin::getCommonStylePath() was removed
..


Skin::getCommonStylePath() was removed

Deprecated since 1.24. No uses in core or Gerrit extensions remaining.

Change-Id: I15629292f00b6d2493f7a329670d85c76da50db9
---
M RELEASE-NOTES-1.27
M includes/skins/Skin.php
2 files changed, 1 insertion(+), 16 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index 97938e2..d91af42 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -392,7 +392,7 @@
 * MediaWikiSite::newFromGlobalId() was removed (deprecated since 1.21).
 * Title::newFromRedirect() was removed (deprecated since 1.21).
 * Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
-
+* Skin::getCommonStylePath() was removed (deprecated since 1.24).
 
 == Compatibility ==
 
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 63b6978..17f5fa4 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -1025,21 +1025,6 @@
}
 
/**
-* This function previously returned a fully resolved style path URL to 
images or styles stored in
-* the legacy skins/common/ directory.
-*
-* That directory has been removed in 1.24 and the function always 
returns an empty string.
-*
-* @deprecated since 1.24
-* @param string $name The name or path of a skin resource file
-* @return string Empty string
-*/
-   function getCommonStylePath( $name ) {
-   wfDeprecated( __METHOD__, '1.24' );
-   return '';
-   }
-
-   /**
 * Return a fully resolved style path url to images or styles stored in 
the current skins's folder.
 * This method returns a url resolved using the configured skin style 
path
 * and includes the style version inside of the url.

-- 
To view, visit https://gerrit.wikimedia.org/r/276058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I15629292f00b6d2493f7a329670d85c76da50db9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Skin::getCommonStylePath() was removed - change (mediawiki/core)

2016-03-08 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/276058

Change subject: Skin::getCommonStylePath() was removed
..

Skin::getCommonStylePath() was removed

Deprecated since 1.24. No uses in core or Gerrit extensions remaining.

Change-Id: I15629292f00b6d2493f7a329670d85c76da50db9
---
M RELEASE-NOTES-1.27
M includes/skins/Skin.php
2 files changed, 1 insertion(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/58/276058/1

diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index c816ce1..c79eb10 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -241,6 +241,7 @@
 * OutputPage::out() was removed (deprecated since 1.22).
 * OutputPage::setAllowedModules() was removed (deprecated since 1.24).
 * Skin::commonPrintStylesheet() was removed (deprecated since 1.22).
+* Skin::getCommonStylePath() was removed (deprecated since 1.24).
 * UserrightsPage::makeGroupNameListForLog() was removed (deprecated since 
1.21).
 
 === Languages updated in 1.27 ===
diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php
index 232c0c9..3adcc7e 100644
--- a/includes/skins/Skin.php
+++ b/includes/skins/Skin.php
@@ -1023,21 +1023,6 @@
}
 
/**
-* This function previously returned a fully resolved style path URL to 
images or styles stored in
-* the legacy skins/common/ directory.
-*
-* That directory has been removed in 1.24 and the function always 
returns an empty string.
-*
-* @deprecated since 1.24
-* @param string $name The name or path of a skin resource file
-* @return string Empty string
-*/
-   function getCommonStylePath( $name ) {
-   wfDeprecated( __METHOD__, '1.24' );
-   return '';
-   }
-
-   /**
 * Return a fully resolved style path url to images or styles stored in 
the current skins's folder.
 * This method returns a url resolved using the configured skin style 
path
 * and includes the style version inside of the url.

-- 
To view, visit https://gerrit.wikimedia.org/r/276058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15629292f00b6d2493f7a329670d85c76da50db9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits