[MediaWiki-commits] [Gerrit] Special:Statistics: Change link target for content pages to ... - change (mediawiki/core)

2015-12-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Special:Statistics: Change link target for content pages to 
hide redirects
..


Special:Statistics: Change link target for content pages to hide redirects

Content pages, as visible on Special:Statistics, doesn't include
redirects in the visible counter. But the link target (Special:AllPages)
includes redirects in the default view, which could be confusing, if a
user expects all pages excluding redirects.

Change the link target of Content pages to hide redirects by default and
add a link for "Pages" to the default view of Special:AllPages.

Change-Id: I1c1ada8e3d16d19db8315eccfbea2c753814659e
---
M includes/specials/SpecialStatistics.php
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialStatistics.php 
b/includes/specials/SpecialStatistics.php
index e06bae0..a989aac 100644
--- a/includes/specials/SpecialStatistics.php
+++ b/includes/specials/SpecialStatistics.php
@@ -114,16 +114,18 @@
 * @return string
 */
private function getPageStats() {
+   $specialAllPagesTitle = SpecialPage::getTitleFor( 'Allpages' );
$pageStatsHtml = Xml::openElement( 'tr' ) .
Xml::tags( 'th', array( 'colspan' => '2' ), $this->msg( 
'statistics-header-pages' )
->parse() ) .
Xml::closeElement( 'tr' ) .
-   $this->formatRow( Linker::linkKnown( 
SpecialPage::getTitleFor( 'Allpages' ),
-   $this->msg( 'statistics-articles' 
)->parse() ),
+   $this->formatRow( Linker::linkKnown( 
$specialAllPagesTitle,
+   $this->msg( 'statistics-articles' 
)->parse(), array(), array( 'hideredirects' => 1 ) ),
$this->getLanguage()->formatNum( 
$this->good ),
array( 'class' => 
'mw-statistics-articles' ),
'statistics-articles-desc' ) .
-   $this->formatRow( $this->msg( 
'statistics-pages' )->parse(),
+   $this->formatRow( Linker::linkKnown( 
$specialAllPagesTitle,
+   $this->msg( 'statistics-pages' 
)->parse() ),
$this->getLanguage()->formatNum( 
$this->total ),
array( 'class' => 'mw-statistics-pages' 
),
'statistics-pages-desc' );

-- 
To view, visit https://gerrit.wikimedia.org/r/250647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c1ada8e3d16d19db8315eccfbea2c753814659e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Special:Statistics: Change link target for content pages to ... - change (mediawiki/core)

2015-11-03 Thread Florianschmidtwelzow (Code Review) 
Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/250647

Change subject: Special:Statistics: Change link target for content pages to 
hide redirects
..

Special:Statistics: Change link target for content pages to hide redirects

Content pages, as visible on Special:Statistics, doesn't include
redirects in the visible counter. But the link target (Special:AllPages)
includes redirects in the default view, which could be confusing, if a
user expects all pages excluding redirects.

Change the link target of Content pages to hide redirects by default and
add a link for "Pages" to the default view of Special:AllPages.

Change-Id: I1c1ada8e3d16d19db8315eccfbea2c753814659e
---
M includes/specials/SpecialStatistics.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/47/250647/1

diff --git a/includes/specials/SpecialStatistics.php 
b/includes/specials/SpecialStatistics.php
index e06bae0..a989aac 100644
--- a/includes/specials/SpecialStatistics.php
+++ b/includes/specials/SpecialStatistics.php
@@ -114,16 +114,18 @@
 * @return string
 */
private function getPageStats() {
+   $specialAllPagesTitle = SpecialPage::getTitleFor( 'Allpages' );
$pageStatsHtml = Xml::openElement( 'tr' ) .
Xml::tags( 'th', array( 'colspan' => '2' ), $this->msg( 
'statistics-header-pages' )
->parse() ) .
Xml::closeElement( 'tr' ) .
-   $this->formatRow( Linker::linkKnown( 
SpecialPage::getTitleFor( 'Allpages' ),
-   $this->msg( 'statistics-articles' 
)->parse() ),
+   $this->formatRow( Linker::linkKnown( 
$specialAllPagesTitle,
+   $this->msg( 'statistics-articles' 
)->parse(), array(), array( 'hideredirects' => 1 ) ),
$this->getLanguage()->formatNum( 
$this->good ),
array( 'class' => 
'mw-statistics-articles' ),
'statistics-articles-desc' ) .
-   $this->formatRow( $this->msg( 
'statistics-pages' )->parse(),
+   $this->formatRow( Linker::linkKnown( 
$specialAllPagesTitle,
+   $this->msg( 'statistics-pages' 
)->parse() ),
$this->getLanguage()->formatNum( 
$this->total ),
array( 'class' => 'mw-statistics-pages' 
),
'statistics-pages-desc' );

-- 
To view, visit https://gerrit.wikimedia.org/r/250647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c1ada8e3d16d19db8315eccfbea2c753814659e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits