[MediaWiki-commits] [Gerrit] Start sampling regular & slow requests - change (operations/puppet)

2016-03-31 Thread Yuvipanda (Code Review) 
Yuvipanda has submitted this change and it was merged.

Change subject: Start sampling regular & slow requests
..


Start sampling regular & slow requests

We need a better understanding of normal requests, without adding undue burden
on our logging infrastructure. To this end, this patch leverages
service-runner logger functionality to configure sampled logging of normal &
slow requests, aiming for a logging rate of no more than about one log message
per minute.

Change-Id: I972271b23b71cf5e954add6e7c92f37770ac6d77
---
M modules/restbase/templates/config.yaml.erb
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Yuvipanda: Verified; Looks good to me, approved



diff --git a/modules/restbase/templates/config.yaml.erb 
b/modules/restbase/templates/config.yaml.erb
index ecfb08c..8b84fb4 100644
--- a/modules/restbase/templates/config.yaml.erb
+++ b/modules/restbase/templates/config.yaml.erb
@@ -891,6 +891,11 @@
 logging:
   name: <%= @logging_name %>
   level: <%= @logging_level %>
+  sampled_levels:
+# Target is about 1 request logged per minute @1000 req/s
+trace/request: 0.1
+# Not sure what the rate of these is, so start conservatively.
+trace/request/slow: 0.0001
   streams:
   # XXX: Use gelf-stream -> logstash
   - type: gelf

-- 
To view, visit https://gerrit.wikimedia.org/r/280711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I972271b23b71cf5e954add6e7c92f37770ac6d77
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: GWicke 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Eevans 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: Yuvipanda 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Start sampling regular & slow requests - change (operations/puppet)

2016-03-31 Thread GWicke (Code Review) 
GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/280711

Change subject: Start sampling regular & slow requests
..

Start sampling regular & slow requests

We need a better understanding of normal requests, without adding undue burden
on our logging infrastructure. To this end, this patch leverages
service-runner logger functionality to configure sampled logging of normal &
slow requests, aiming for a logging rate of no more than about one log message
per minute.

Change-Id: I972271b23b71cf5e954add6e7c92f37770ac6d77
---
M modules/restbase/templates/config.yaml.erb
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/11/280711/1

diff --git a/modules/restbase/templates/config.yaml.erb 
b/modules/restbase/templates/config.yaml.erb
index ecfb08c..8b84fb4 100644
--- a/modules/restbase/templates/config.yaml.erb
+++ b/modules/restbase/templates/config.yaml.erb
@@ -891,6 +891,11 @@
 logging:
   name: <%= @logging_name %>
   level: <%= @logging_level %>
+  sampled_levels:
+# Target is about 1 request logged per minute @1000 req/s
+trace/request: 0.1
+# Not sure what the rate of these is, so start conservatively.
+trace/request/slow: 0.0001
   streams:
   # XXX: Use gelf-stream -> logstash
   - type: gelf

-- 
To view, visit https://gerrit.wikimedia.org/r/280711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I972271b23b71cf5e954add6e7c92f37770ac6d77
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: GWicke 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits