[MediaWiki-commits] [Gerrit] Support for URL params in browser tests - change (mediawiki...ContentTranslation)

2014-01-08 Thread Amire80 (Code Review) 
Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/106246


Change subject: Support for URL params in browser tests
..

Support for URL params in browser tests

Change-Id: I8e0ccd8838d50ca897b36e4fc652bd6574f8dcb0
---
M tests/browser/features/step_definitions/special_content_translation_steps.rb
M tests/browser/features/support/pages/content_translation_page.rb
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/46/106246/1

diff --git 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
index 1fa3568..4ed153c 100644
--- 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
+++ 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
@@ -1,5 +1,5 @@
 Given(/^I am on the content translation page in a wiki in (.+?), translating 
the page (.+?) to (.+)$/) do |source_language, page_name, target_language|
-   pending # express the regexp above with the code you wish you had
+   visit(ContentTranslationPage, :using_params = {:extra = 
title=#{page_name}lang=#{target_language}})
 end
 
 When(/^I press the Publish Translation button$/) do
diff --git a/tests/browser/features/support/pages/content_translation_page.rb 
b/tests/browser/features/support/pages/content_translation_page.rb
index e573f65..69037a5 100644
--- a/tests/browser/features/support/pages/content_translation_page.rb
+++ b/tests/browser/features/support/pages/content_translation_page.rb
@@ -1,7 +1,7 @@
 class ContentTranslationPage
include PageObject
include URL
-   page_url URL.url(Special:ContentTranslation)
+   page_url URL.url(Special:ContentTranslation?%=params[:extra]%)
 
button(:publish_translation, class: publish-translation)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/106246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e0ccd8838d50ca897b36e4fc652bd6574f8dcb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Support for URL params in browser tests - change (mediawiki...ContentTranslation)

2014-01-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Support for URL params in browser tests
..


Support for URL params in browser tests

Change-Id: I8e0ccd8838d50ca897b36e4fc652bd6574f8dcb0
---
M tests/browser/features/step_definitions/special_content_translation_steps.rb
M tests/browser/features/support/pages/content_translation_page.rb
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
index 1fa3568..4ed153c 100644
--- 
a/tests/browser/features/step_definitions/special_content_translation_steps.rb
+++ 
b/tests/browser/features/step_definitions/special_content_translation_steps.rb
@@ -1,5 +1,5 @@
 Given(/^I am on the content translation page in a wiki in (.+?), translating 
the page (.+?) to (.+)$/) do |source_language, page_name, target_language|
-   pending # express the regexp above with the code you wish you had
+   visit(ContentTranslationPage, :using_params = {:extra = 
title=#{page_name}lang=#{target_language}})
 end
 
 When(/^I press the Publish Translation button$/) do
diff --git a/tests/browser/features/support/pages/content_translation_page.rb 
b/tests/browser/features/support/pages/content_translation_page.rb
index e573f65..69037a5 100644
--- a/tests/browser/features/support/pages/content_translation_page.rb
+++ b/tests/browser/features/support/pages/content_translation_page.rb
@@ -1,7 +1,7 @@
 class ContentTranslationPage
include PageObject
include URL
-   page_url URL.url(Special:ContentTranslation)
+   page_url URL.url(Special:ContentTranslation?%=params[:extra]%)
 
button(:publish_translation, class: publish-translation)
 

-- 
To view, visit https://gerrit.wikimedia.org/r/106246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e0ccd8838d50ca897b36e4fc652bd6574f8dcb0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com
Gerrit-Reviewer: SuchetaG sucheta.ghos...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits