[MediaWiki-commits] [Gerrit] Tee tracked events to MediaWiki's mw.track - change (mediawiki...VisualEditor)

2014-01-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Tee tracked events to MediaWiki's mw.track
..


Tee tracked events to MediaWiki's mw.track

When running in the context of MediaWiki, VisualEditor should tee its event
stream to MediaWiki's main event bus, mw.track(), so that MediaWiki event
subscribers have a unified interface for subscribing to events. Each
VisualEditor event topic is prefixed with 've.'

To test this patch, you can use this snippet:

  mw.trackSubscribe( 've', function ( topic, data ) {
console.log( this, topic, data );
  } );

Change-Id: I6b3f10b0dd0aa7fa47c3b35e2fc554622960ce52
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 8d64615..844dba2 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -36,6 +36,13 @@
var target = new 
ve.init.mw.ViewPageTarget();
ve.init.mw.targets.push( target );
 
+   // Tee tracked events to MediaWiki 
firehose, if available (1.23+).
+   if ( mw.track ) {
+   ve.trackSubscribeAll( function 
( topic, data ) {
+   mw.track.call( null, 
've.' + topic, data );
+   } );
+   }
+
// Transfer methods

ve.init.mw.ViewPageTarget.prototype.setupSectionEditLinks = 
init.setupSectionLinks;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/107907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b3f10b0dd0aa7fa47c3b35e2fc554622960ce52
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Tee tracked events to MediaWiki's mw.track - change (mediawiki...VisualEditor)

2014-01-16 Thread Ori.livneh (Code Review) 
Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/107907


Change subject: Tee tracked events to MediaWiki's mw.track
..

Tee tracked events to MediaWiki's mw.track

When running in the context of MediaWiki, VisualEditor should tee its event
stream to MediaWiki's main event bus, mw.track(), so that MediaWiki event
subscribers have a unified interface for subscribing to events. Each
VisualEditor event topic is prefixed with 've.'

To test this patch, you can use this snippet:

  mw.trackSubscribe( '', function ( topic, data ) {
console.log( this, topic, data );
  } );

Note that mw.track() was added in I8c7af097e; if backward-compatibility is
required, the block may be wrapped with a check for mw.track.

Change-Id: I6b3f10b0dd0aa7fa47c3b35e2fc554622960ce52
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/07/107907/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index 8d64615..649dc81 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -36,6 +36,11 @@
var target = new 
ve.init.mw.ViewPageTarget();
ve.init.mw.targets.push( target );
 
+   // Tee tracked events to MediaWiki 
firehose
+   ve.trackSubscribeAll( function ( topic, 
data ) {
+   mw.track.call( null, 've.' + 
topic, data );
+   } );
+
// Transfer methods

ve.init.mw.ViewPageTarget.prototype.setupSectionEditLinks = 
init.setupSectionLinks;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/107907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b3f10b0dd0aa7fa47c3b35e2fc554622960ce52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits