[MediaWiki-commits] [Gerrit] Timestamp params (no longer Message-escaped()) still need t... - change (mediawiki...ArticleFeedbackv5)
Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/61356 Change subject: Timestamp params (no longer Message-escaped()) still need to be escaped .. Timestamp params (no longer Message-escaped()) still need to be escaped Change-Id: I1af17c01395f5affaa3ef1ac4c31881a05d12232 --- M ArticleFeedbackv5.render.php M ArticleFeedbackv5.utils.php 2 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 refs/changes/56/61356/1 diff --git a/ArticleFeedbackv5.render.php b/ArticleFeedbackv5.render.php index 9267f82..55e7a12 100644 --- a/ArticleFeedbackv5.render.php +++ b/ArticleFeedbackv5.render.php @@ -483,7 +483,7 @@ Html::rawElement( 'span', array( 'class' = 'articleFeedbackv5-comment-details' ), - Html::rawElement( + Html::element( 'span', array( 'class' = 'articleFeedbackv5-comment-details-date' ), $timestamp-getHumanTimestamp() @@ -1237,7 +1237,7 @@ array( 'class' = 'articleFeedbackv5-feedback-permalink-status articleFeedbackv5-laststatus-' . $last-log_action ), wfMessage( 'articlefeedbackv5-permalink-status-' . $last-log_action ) -rawParams( ArticleFeedbackv5Utils::getUserLink( $last-log_user, $last-log_user_text ) ) - -rawParams( $timestamp-getHumanTimestamp() ) + -params( $timestamp-getHumanTimestamp() ) -parse() ) ) . diff --git a/ArticleFeedbackv5.utils.php b/ArticleFeedbackv5.utils.php index d41e471..2cb53ad 100644 --- a/ArticleFeedbackv5.utils.php +++ b/ArticleFeedbackv5.utils.php @@ -256,8 +256,7 @@ // articlefeedbackv5-mask-text-oversight, articlefeedbackv5-mask-text-hide, // articlefeedbackv5-mask-text-inappropriate return wfMessage( 'articlefeedbackv5-mask-text-' . $type ) - -params( static::formatId( $feedbackId ), $username ) - -rawParams( $timestamp-getHumanTimestamp() ) + -params( static::formatId( $feedbackId ), $username, $timestamp-getHumanTimestamp() ) -escaped(); } -- To view, visit https://gerrit.wikimedia.org/r/61356 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1af17c01395f5affaa3ef1ac4c31881a05d12232 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Timestamp params (no longer Message-escaped()) still need t... - change (mediawiki...ArticleFeedbackv5)
jenkins-bot has submitted this change and it was merged. Change subject: Timestamp params (no longer Message-escaped()) still need to be escaped .. Timestamp params (no longer Message-escaped()) still need to be escaped Change-Id: I1af17c01395f5affaa3ef1ac4c31881a05d12232 --- M ArticleFeedbackv5.render.php M ArticleFeedbackv5.utils.php 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/ArticleFeedbackv5.render.php b/ArticleFeedbackv5.render.php index 9267f82..55e7a12 100644 --- a/ArticleFeedbackv5.render.php +++ b/ArticleFeedbackv5.render.php @@ -483,7 +483,7 @@ Html::rawElement( 'span', array( 'class' = 'articleFeedbackv5-comment-details' ), - Html::rawElement( + Html::element( 'span', array( 'class' = 'articleFeedbackv5-comment-details-date' ), $timestamp-getHumanTimestamp() @@ -1237,7 +1237,7 @@ array( 'class' = 'articleFeedbackv5-feedback-permalink-status articleFeedbackv5-laststatus-' . $last-log_action ), wfMessage( 'articlefeedbackv5-permalink-status-' . $last-log_action ) -rawParams( ArticleFeedbackv5Utils::getUserLink( $last-log_user, $last-log_user_text ) ) - -rawParams( $timestamp-getHumanTimestamp() ) + -params( $timestamp-getHumanTimestamp() ) -parse() ) ) . diff --git a/ArticleFeedbackv5.utils.php b/ArticleFeedbackv5.utils.php index d41e471..2cb53ad 100644 --- a/ArticleFeedbackv5.utils.php +++ b/ArticleFeedbackv5.utils.php @@ -256,8 +256,7 @@ // articlefeedbackv5-mask-text-oversight, articlefeedbackv5-mask-text-hide, // articlefeedbackv5-mask-text-inappropriate return wfMessage( 'articlefeedbackv5-mask-text-' . $type ) - -params( static::formatId( $feedbackId ), $username ) - -rawParams( $timestamp-getHumanTimestamp() ) + -params( static::formatId( $feedbackId ), $username, $timestamp-getHumanTimestamp() ) -escaped(); } -- To view, visit https://gerrit.wikimedia.org/r/61356 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1af17c01395f5affaa3ef1ac4c31881a05d12232 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Matthias Mullie mmul...@wikimedia.org Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
