[MediaWiki-commits] [Gerrit] "Translate" to English in English translation stash - change (mediawiki...Translate)
jenkins-bot has submitted this change and it was merged. Change subject: "Translate" to English in English translation stash .. "Translate" to English in English translation stash Selecting a random language means we have 99 % chance to pick one the user doesn't know. It's less meaningless to ask translations to the source language, which the translator is expected to know. Bug: T75664 Change-Id: If64d113b0153fe0e82c6198a50c569078a180a69 --- M specials/SpecialTranslationStash.php 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/specials/SpecialTranslationStash.php b/specials/SpecialTranslationStash.php index a6bba7c..7298ecb 100644 --- a/specials/SpecialTranslationStash.php +++ b/specials/SpecialTranslationStash.php @@ -200,8 +200,7 @@ } } - // User has not chosen any valid language. Pick one at random. - $codes = array_keys( $supported ); - return Language::factory( $codes[rand( 0, count( $codes ) - 1 )] ); + // User has not chosen any valid language. Pick the source. + return $source->getCode(); } } -- To view, visit https://gerrit.wikimedia.org/r/213482 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If64d113b0153fe0e82c6198a50c569078a180a69 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nemo bis Gerrit-Reviewer: Nikerabbit Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] "Translate" to English in English translation stash - change (mediawiki...Translate)
Nemo bis has uploaded a new change for review. https://gerrit.wikimedia.org/r/213482 Change subject: "Translate" to English in English translation stash .. "Translate" to English in English translation stash Selecting a random language means we have 99 % chance to pick one the user doesn't know. It's less meaningless to ask translations to the source language, which the translator is expected to know. Bug: T75664 Change-Id: If64d113b0153fe0e82c6198a50c569078a180a69 --- M specials/SpecialTranslationStash.php 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/82/213482/1 diff --git a/specials/SpecialTranslationStash.php b/specials/SpecialTranslationStash.php index a6bba7c..7298ecb 100644 --- a/specials/SpecialTranslationStash.php +++ b/specials/SpecialTranslationStash.php @@ -200,8 +200,7 @@ } } - // User has not chosen any valid language. Pick one at random. - $codes = array_keys( $supported ); - return Language::factory( $codes[rand( 0, count( $codes ) - 1 )] ); + // User has not chosen any valid language. Pick the source. + return $source->getCode(); } } -- To view, visit https://gerrit.wikimedia.org/r/213482 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If64d113b0153fe0e82c6198a50c569078a180a69 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nemo bis ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
