[MediaWiki-commits] [Gerrit] Turn off Special:HideBanners filter - change (operations/puppet)

2014-10-23 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168298

Change subject: Turn off Special:HideBanners filter
..

Turn off Special:HideBanners filter

No longer needed now that old cookie JS is gone.

Change-Id: I331063c3e268557f24811ac11abab8933901f191
---
M templates/udp2log/filters.erbium.erb
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/98/168298/1

diff --git a/templates/udp2log/filters.erbium.erb 
b/templates/udp2log/filters.erbium.erb
index 1d3cd33..44f9785 100644
--- a/templates/udp2log/filters.erbium.erb
+++ b/templates/udp2log/filters.erbium.erb
@@ -13,9 +13,6 @@
 pipe 100 /usr/bin/udp-filter -F '\t' -p Special:RecordImpression  %= 
@template_variables['fundraising_log_directory'] 
%/logs/bannerImpressions-sampled100.tsv.log
 pipe 100 /usr/bin/udp-filter -F '\t' -p Special:BannerRandom  %= 
@template_variables['fundraising_log_directory'] 
%/logs/bannerRequests-sampled100.tsv.log
 
-## RT 8060
-pipe 100 /usr/bin/udp-filter -F '\t' -d meta.wikimedia.org -p 
Special:HideBanners  %= @template_variables['fundraising_log_directory'] 
%/logs/hideBanners-sampled100.tsv.log
-
 ### API Usage
 pipe 100 /usr/bin/udp-filter -F '\t' -p /w/api.php  %= 
scope.lookupvar('role::logging::udp2log::erbium::webrequest_log_directory') 
%/api-usage.tsv.log
 

-- 
To view, visit https://gerrit.wikimedia.org/r/168298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I331063c3e268557f24811ac11abab8933901f191
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ejegg eeggles...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Turn off Special:HideBanners filter - change (operations/puppet)

2014-10-23 Thread Jgreen (Code Review)
Jgreen has submitted this change and it was merged.

Change subject: Turn off Special:HideBanners filter
..


Turn off Special:HideBanners filter

No longer needed now that old cookie JS is gone.

Change-Id: I331063c3e268557f24811ac11abab8933901f191
---
M templates/udp2log/filters.erbium.erb
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jgreen: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/templates/udp2log/filters.erbium.erb 
b/templates/udp2log/filters.erbium.erb
index 1d3cd33..44f9785 100644
--- a/templates/udp2log/filters.erbium.erb
+++ b/templates/udp2log/filters.erbium.erb
@@ -13,9 +13,6 @@
 pipe 100 /usr/bin/udp-filter -F '\t' -p Special:RecordImpression  %= 
@template_variables['fundraising_log_directory'] 
%/logs/bannerImpressions-sampled100.tsv.log
 pipe 100 /usr/bin/udp-filter -F '\t' -p Special:BannerRandom  %= 
@template_variables['fundraising_log_directory'] 
%/logs/bannerRequests-sampled100.tsv.log
 
-## RT 8060
-pipe 100 /usr/bin/udp-filter -F '\t' -d meta.wikimedia.org -p 
Special:HideBanners  %= @template_variables['fundraising_log_directory'] 
%/logs/hideBanners-sampled100.tsv.log
-
 ### API Usage
 pipe 100 /usr/bin/udp-filter -F '\t' -p /w/api.php  %= 
scope.lookupvar('role::logging::udp2log::erbium::webrequest_log_directory') 
%/api-usage.tsv.log
 

-- 
To view, visit https://gerrit.wikimedia.org/r/168298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I331063c3e268557f24811ac11abab8933901f191
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ejegg eeggles...@wikimedia.org
Gerrit-Reviewer: Jgreen jgr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits