[MediaWiki-commits] [Gerrit] Unset 'action' query parameter from veEditUri, which should ... - change (mediawiki...VisualEditor)

2015-11-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Unset 'action' query parameter from veEditUri, which should 
always point to VE
..


Unset 'action' query parameter from veEditUri, which should always point to VE

Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 8b042e8..0270920 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -231,6 +231,7 @@
// On a view page, extend the current URI so parameters like oldid are 
carried over
// On a non-view page, use viewUri
veEditUri = ( pageCanLoadVE ? uri : viewUri ).clone().extend( { 
veaction: 'edit' } );
+   delete veEditUri.query.action;
 
support = {
es5: !!(

-- 
To view, visit https://gerrit.wikimedia.org/r/251843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Unset 'action' query parameter from veEditUri, which should ... - change (mediawiki...VisualEditor)

2015-11-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Unset 'action' query parameter from veEditUri, which should 
always point to VE
..


Unset 'action' query parameter from veEditUri, which should always point to VE

Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
(cherry picked from commit 1e4889bbc7ccafd373a16c42167b83b524f480fd)
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 3b6f091..b820338 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -231,6 +231,7 @@
// On a view page, extend the current URI so parameters like oldid are 
carried over
// On a non-view page, use viewUri
veEditUri = ( pageCanLoadVE ? uri : viewUri ).clone().extend( { 
veaction: 'edit' } );
+   delete veEditUri.query.action;
 
support = {
es5: !!(

-- 
To view, visit https://gerrit.wikimedia.org/r/251969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.27.0-wmf.5
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Unset 'action' query parameter from veEditUri, which should ... - change (mediawiki...VisualEditor)

2015-11-09 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/251969

Change subject: Unset 'action' query parameter from veEditUri, which should 
always point to VE
..

Unset 'action' query parameter from veEditUri, which should always point to VE

Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
(cherry picked from commit 1e4889bbc7ccafd373a16c42167b83b524f480fd)
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/69/251969/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 3b6f091..b820338 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -231,6 +231,7 @@
// On a view page, extend the current URI so parameters like oldid are 
carried over
// On a non-view page, use viewUri
veEditUri = ( pageCanLoadVE ? uri : viewUri ).clone().extend( { 
veaction: 'edit' } );
+   delete veEditUri.query.action;
 
support = {
es5: !!(

-- 
To view, visit https://gerrit.wikimedia.org/r/251969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.27.0-wmf.5
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Unset 'action' query parameter from veEditUri, which should ... - change (mediawiki...VisualEditor)

2015-11-08 Thread Alex Monk (Code Review) 
Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/251843

Change subject: Unset 'action' query parameter from veEditUri, which should 
always point to VE
..

Unset 'action' query parameter from veEditUri, which should always point to VE

Bug: T117780
Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/43/251843/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 8b042e8..0270920 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -231,6 +231,7 @@
// On a view page, extend the current URI so parameters like oldid are 
carried over
// On a non-view page, use viewUri
veEditUri = ( pageCanLoadVE ? uri : viewUri ).clone().extend( { 
veaction: 'edit' } );
+   delete veEditUri.query.action;
 
support = {
es5: !!(

-- 
To view, visit https://gerrit.wikimedia.org/r/251843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1377145bbbe05611ee75ae27922cf7a2cc5895e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits