[MediaWiki-commits] [Gerrit] Updated SMWQueryProcessor API - change (mediawiki...SemanticMediaWiki[master])

2012-11-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Updated SMWQueryProcessor API
..


Updated SMWQueryProcessor API

* Disentagled some code in print request parsing
* Use array results instead of making part of the parameters call-by-ref to 
return outputs
* Update #ask and #show to make query object first and then create result (the 
query object will be needed to certain data later on)
* Deprecated a number of functions

Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb
---
M includes/SMW_QueryProcessor.php
M includes/api/ApiAsk.php
M includes/parserhooks/SMW_Ask.php
M includes/parserhooks/SMW_Concept.php
M includes/parserhooks/SMW_Show.php
M specials/AskSpecial/SMW_QueryUIHelper.php
M specials/AskSpecial/SMW_SpecialAsk.php
M tests/phpunit/includes/QueryProcessorTest.php
M tests/phpunit/includes/storage/StoreTest.php
9 files changed, 306 insertions(+), 192 deletions(-)

Approvals:
  Jeroen De Dauw: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/31557
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de
Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de
Gerrit-Reviewer: Foxtrott s7ep...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: Nischayn22 nischay...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Updated SMWQueryProcessor API - change (mediawiki...SemanticMediaWiki[master])

2012-11-02 Thread Markus Kroetzsch (Code Review)
Markus Kroetzsch has uploaded a new change for review.

Change subject: Updated SMWQueryProcessor API
..

Updated SMWQueryProcessor API

* Disentagled some code in print request parsing
* Use array results instead of making part of the parameters call-by-ref to 
return outputs
* Update #ask and #show to make query object first and then create result (the 
query object will be needed to certain data later on)
* Deprecated a number of functions

Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb
---
M includes/SMW_QueryProcessor.php
M includes/api/ApiAsk.php
M includes/parserhooks/SMW_Ask.php
M includes/parserhooks/SMW_Concept.php
M includes/parserhooks/SMW_Show.php
M specials/AskSpecial/SMW_QueryUIHelper.php
M specials/AskSpecial/SMW_SpecialAsk.php
M tests/phpunit/includes/QueryProcessorTest.php
M tests/phpunit/includes/storage/StoreTest.php
9 files changed, 307 insertions(+), 194 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/57/31557/1
--
To view, visit https://gerrit.wikimedia.org/r/31557
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits