[MediaWiki-commits] [Gerrit] Use canonical class name, remove unused globals. - change (mediawiki/core)

2013-09-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Use canonical class name, remove unused globals.
..


Use canonical class name, remove unused globals.

Change-Id: I94cf491e4c1c793f455fd597b383f8133b0aace3
---
M includes/SkinTemplate.php
M includes/rcfeed/JSONRCFeedFormatter.php
M includes/specials/SpecialListfiles.php
3 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Matmarex: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 2739df3..1b766ab 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -589,8 +589,6 @@
 * @return array
 */
protected function buildPersonalUrls() {
-   global $wgSecureLogin;
-
$title = $this-getTitle();
$request = $this-getRequest();
$pageurl = $title-getLocalURL();
diff --git a/includes/rcfeed/JSONRCFeedFormatter.php 
b/includes/rcfeed/JSONRCFeedFormatter.php
index d50139c..f4cb992 100644
--- a/includes/rcfeed/JSONRCFeedFormatter.php
+++ b/includes/rcfeed/JSONRCFeedFormatter.php
@@ -1,11 +1,12 @@
 ?php
+
 class JSONRCFeedFormatter implements RCFeedFormatter {
/**
 * Generates a notification that can be easily interpreted by a machine.
 * @see RCFeedFormatter::getLine
 */
public function getLine( array $feed, RecentChange $rc, $actionComment 
) {
-   global $wgCanonicalServer, $wgScriptPath, $wgArticlePath, 
$wgDBname;
+   global $wgCanonicalServer, $wgScriptPath, $wgDBname;
$attrib = $rc-getAttributes();
 
$packet = array(
diff --git a/includes/specials/SpecialListfiles.php 
b/includes/specials/SpecialListfiles.php
index 9377628..d939bd1 100644
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -471,7 +471,7 @@
'tabindex' = 3,
) );
 
-   $inputForm['listfiles-show-all'] = HTML::input( 'ilshowall', 1, 
'checkbox', array(
+   $inputForm['listfiles-show-all'] = Html::input( 'ilshowall', 1, 
'checkbox', array(
'checked' = $this-mShowAll,
'tabindex' = 4,
) );

-- 
To view, visit https://gerrit.wikimedia.org/r/81875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94cf491e4c1c793f455fd597b383f8133b0aace3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides platoni...@gmail.com
Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com
Gerrit-Reviewer: Jack Phoenix j...@countervandalism.net
Gerrit-Reviewer: Matmarex matma@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Use canonical class name, remove unused globals. - change (mediawiki/core)

2013-08-29 Thread Platonides (Code Review) 
Platonides has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81875


Change subject: Use canonical class name, remove unused globals.
..

Use canonical class name, remove unused globals.

Change-Id: I94cf491e4c1c793f455fd597b383f8133b0aace3
---
M includes/SkinTemplate.php
M includes/rcfeed/JSONRCFeedFormatter.php
M includes/specials/SpecialListfiles.php
3 files changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/75/81875/1

diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index 2739df3..1b766ab 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -589,8 +589,6 @@
 * @return array
 */
protected function buildPersonalUrls() {
-   global $wgSecureLogin;
-
$title = $this-getTitle();
$request = $this-getRequest();
$pageurl = $title-getLocalURL();
diff --git a/includes/rcfeed/JSONRCFeedFormatter.php 
b/includes/rcfeed/JSONRCFeedFormatter.php
index d50139c..f4cb992 100644
--- a/includes/rcfeed/JSONRCFeedFormatter.php
+++ b/includes/rcfeed/JSONRCFeedFormatter.php
@@ -1,11 +1,12 @@
 ?php
+
 class JSONRCFeedFormatter implements RCFeedFormatter {
/**
 * Generates a notification that can be easily interpreted by a machine.
 * @see RCFeedFormatter::getLine
 */
public function getLine( array $feed, RecentChange $rc, $actionComment 
) {
-   global $wgCanonicalServer, $wgScriptPath, $wgArticlePath, 
$wgDBname;
+   global $wgCanonicalServer, $wgScriptPath, $wgDBname;
$attrib = $rc-getAttributes();
 
$packet = array(
diff --git a/includes/specials/SpecialListfiles.php 
b/includes/specials/SpecialListfiles.php
index 9377628..d939bd1 100644
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -471,7 +471,7 @@
'tabindex' = 3,
) );
 
-   $inputForm['listfiles-show-all'] = HTML::input( 'ilshowall', 1, 
'checkbox', array(
+   $inputForm['listfiles-show-all'] = Html::input( 'ilshowall', 1, 
'checkbox', array(
'checked' = $this-mShowAll,
'tabindex' = 4,
) );

-- 
To view, visit https://gerrit.wikimedia.org/r/81875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94cf491e4c1c793f455fd597b383f8133b0aace3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Platonides platoni...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits