[MediaWiki-commits] [Gerrit] Use parens to clarify intent functionality of a condition - change (apps...commons)
Brion VIBBER has submitted this change and it was merged.
Change subject: Use parens to clarify intent functionality of a condition
..
Use parens to clarify intent functionality of a condition
Precedence rules are for chumps.
Change-Id: I5e46899b3d2e2af32b627e8cd61f085ad28ef2a2
---
M commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git
a/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
b/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
index 57bfd43..1cdc61a 100644
--- a/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
+++ b/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
@@ -182,7 +182,7 @@
if (response.getBitmap() != null) {
setImageBitmap(response.getBitmap());
-if(tryOriginal mMedia instanceof Contribution
response.getBitmap().getWidth() mMedia.getWidth() ||
response.getBitmap().getHeight() mMedia.getHeight()) {
+if(tryOriginal mMedia instanceof Contribution
(response.getBitmap().getWidth() mMedia.getWidth() ||
response.getBitmap().getHeight() mMedia.getHeight())) {
// If there is no width information for this
image, save it. This speeds up image loading massively for smaller images
mMedia.setHeight(response.getBitmap().getHeight());
mMedia.setWidth(response.getBitmap().getWidth());
--
To view, visit https://gerrit.wikimedia.org/r/85156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e46899b3d2e2af32b627e8cd61f085ad28ef2a2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/commons
Gerrit-Branch: campaigns
Gerrit-Owner: Yuvipanda yuvipa...@gmail.com
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use parens to clarify intent functionality of a condition - change (apps...commons)
Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/85156
Change subject: Use parens to clarify intent functionality of a condition
..
Use parens to clarify intent functionality of a condition
Precedence rules are for chumps.
Change-Id: I5e46899b3d2e2af32b627e8cd61f085ad28ef2a2
---
M commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/commons
refs/changes/56/85156/1
diff --git
a/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
b/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
index 57bfd43..1cdc61a 100644
--- a/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
+++ b/commons/src/main/java/org/wikimedia/commons/MediaWikiImageView.java
@@ -182,7 +182,7 @@
if (response.getBitmap() != null) {
setImageBitmap(response.getBitmap());
-if(tryOriginal mMedia instanceof Contribution
response.getBitmap().getWidth() mMedia.getWidth() ||
response.getBitmap().getHeight() mMedia.getHeight()) {
+if(tryOriginal mMedia instanceof Contribution
(response.getBitmap().getWidth() mMedia.getWidth() ||
response.getBitmap().getHeight() mMedia.getHeight())) {
// If there is no width information for this
image, save it. This speeds up image loading massively for smaller images
mMedia.setHeight(response.getBitmap().getHeight());
mMedia.setWidth(response.getBitmap().getWidth());
--
To view, visit https://gerrit.wikimedia.org/r/85156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e46899b3d2e2af32b627e8cd61f085ad28ef2a2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/commons
Gerrit-Branch: campaigns
Gerrit-Owner: Yuvipanda yuvipa...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
