jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363490 )
Change subject: LanguageInputWidget: optionally suppress directionality input
..
LanguageInputWidget: optionally suppress directionality input
This allows use for language selection where directionality isn't
relevant, for example in LanguageConverter markup.
Change-Id: If53084fb1c5f9b71435fd6edd1aa9a547689dd60
---
M demos/ve/ve.demo.init.js
M src/ui/widgets/ve.ui.LanguageInputWidget.js
2 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/demos/ve/ve.demo.init.js b/demos/ve/ve.demo.init.js
index cacdb40..c821e9d 100644
--- a/demos/ve/ve.demo.init.js
+++ b/demos/ve/ve.demo.init.js
@@ -23,7 +23,7 @@
} ),
languageInput = new ve.ui.LanguageInputWidget( {
- requireDir: true,
+ dirInput: 'no-auto',
hideCodeInput: true,
availableLanguages: ve.availableLanguages,
dialogManager: new OO.ui.WindowManager( { factory:
ve.ui.windowFactory, classes: [ 've-demo-languageSearchDialogManager' ] } )
diff --git a/src/ui/widgets/ve.ui.LanguageInputWidget.js
b/src/ui/widgets/ve.ui.LanguageInputWidget.js
index 8b1725b..8710502 100644
--- a/src/ui/widgets/ve.ui.LanguageInputWidget.js
+++ b/src/ui/widgets/ve.ui.LanguageInputWidget.js
@@ -12,16 +12,18 @@
*
* @constructor
* @param {Object} [config] Configuration options
- * @cfg {boolean} [requireDir] Require directionality to be set (no 'auto'
value)
+ * @cfg {string} [dirInput="auto"] Set to "none" to hide the directionality
input; set to "no-auto" to select between LTR and RTL; set to "auto" to add
"auto" to directionality options.
* @cfg {boolean} [hideCodeInput] Prevent user from entering a language code
as free text
* @cfg {ve.ui.WindowManager} [dialogManager] Window manager to launch the
language search dialog in
* @cfg {string[]} [availableLanguages] Available language codes to show in
search dialog
*/
ve.ui.LanguageInputWidget = function VeUiLanguageInputWidget( config ) {
- var dirItems;
+ var dirItems,
+ dirInput;
// Configuration initialization
config = config || {};
+ dirInput = ( config.dirInput === undefined ) ? 'auto' : config.dirInput;
// Parent constructor
ve.ui.LanguageInputWidget.super.call( this, config );
@@ -84,7 +86,7 @@
icon: 'textDirLTR'
} )
];
- if ( !config.requireDir ) {
+ if ( dirInput === 'auto' ) {
dirItems.splice(
1, 0, new OO.ui.ButtonOptionWidget( {
data: null,
@@ -98,10 +100,10 @@
this.$element
.addClass( 've-ui-languageInputWidget' )
- .append(
- this.languageLayout.$element,
- this.directionField.$element
- );
+ .append( this.languageLayout.$element );
+ if ( dirInput !== 'none' ) {
+ this.$element.append( this.directionField.$element );
+ }
};
/* Inheritance */
--
To view, visit https://gerrit.wikimedia.org/r/363490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If53084fb1c5f9b71435fd6edd1aa9a547689dd60
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: C. Scott Ananian
Gerrit-Reviewer: C. Scott Ananian
Gerrit-Reviewer: Esanders
Gerrit-Reviewer: Jforrester
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
