[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Enforce dm unit test coverage at 20% per file and 80%...
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/347800 ) Change subject: tests: Enforce dm unit test coverage at 20% per file and 80% globally .. tests: Enforce dm unit test coverage at 20% per file and 80% globally Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54 --- M Gruntfile.js 1 file changed, 41 insertions(+), 1 deletion(-) Approvals: Esanders: Looks good to me, but someone else must approve Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/Gruntfile.js b/Gruntfile.js index 5462266..fa14180 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -325,7 +325,47 @@ { type: 'json-summary', dir: 'coverage/' }, { type: 'html', dir: 'coverage/' }, { type: 'text-summary', dir: 'coverage/' } - ] + ], + // https://github.com/karma-runner/karma-coverage/blob/v1.1.1/docs/configuration.md#check + check: { + global: { + functions: 60, + branches: 60, + statements: 60, + lines: 60, + overrides: { + 'src/dm/*.js': { + functions: 80, + branches: 80, + statements: 80, + lines: 80 + }, + 'src/dm/**/*.js': { + functions: 80, + branches: 80, + statements: 80, + lines: 80 + } + } + }, + each: { + functions: 20, + branches: 20, + statements: 20, + lines: 20, + excludes: [ + 'src/ve.track.js', + 'src/init/**/*.js', + 'src/ce/**/*.js', + 'src/ui/**/*.js', + 'src/dm/ve.dm.SurfaceSynchronizer.js', + 'src/dm/ve.dm.TableSlice.js', + 'src/dm/annotations/ve.dm.BidiAnnotation.js', + 'src/dm/metaitems/ve.dm.CommentMetaItem.js', + 'src/dm/nodes/ve.dm.GeneratedContentNode.js' + ] + } + } } }, others: { -- To view, visit https://gerrit.wikimedia.org/r/347800 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54 Gerrit-PatchSet: 3 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester Gerrit-Reviewer: Catrope Gerrit-Reviewer: Divec Gerrit-Reviewer: Esanders Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: tests: Enforce dm unit test coverage at 20% per file and 80%...
Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347800 ) Change subject: tests: Enforce dm unit test coverage at 20% per file and 80% globally .. tests: Enforce dm unit test coverage at 20% per file and 80% globally Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54 --- M Gruntfile.js 1 file changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/00/347800/1 diff --git a/Gruntfile.js b/Gruntfile.js index 5462266..fa14180 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -325,7 +325,47 @@ { type: 'json-summary', dir: 'coverage/' }, { type: 'html', dir: 'coverage/' }, { type: 'text-summary', dir: 'coverage/' } - ] + ], + // https://github.com/karma-runner/karma-coverage/blob/v1.1.1/docs/configuration.md#check + check: { + global: { + functions: 60, + branches: 60, + statements: 60, + lines: 60, + overrides: { + 'src/dm/*.js': { + functions: 80, + branches: 80, + statements: 80, + lines: 80 + }, + 'src/dm/**/*.js': { + functions: 80, + branches: 80, + statements: 80, + lines: 80 + } + } + }, + each: { + functions: 20, + branches: 20, + statements: 20, + lines: 20, + excludes: [ + 'src/ve.track.js', + 'src/init/**/*.js', + 'src/ce/**/*.js', + 'src/ui/**/*.js', + 'src/dm/ve.dm.SurfaceSynchronizer.js', + 'src/dm/ve.dm.TableSlice.js', + 'src/dm/annotations/ve.dm.BidiAnnotation.js', + 'src/dm/metaitems/ve.dm.CommentMetaItem.js', + 'src/dm/nodes/ve.dm.GeneratedContentNode.js' + ] + } + } } }, others: { -- To view, visit https://gerrit.wikimedia.org/r/347800 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a95c2da3ab471339e7a9617027abbb2074dda54 Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Jforrester ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits