[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Support consumption from multiple topics

2018-01-03 Thread Ottomata (Code Review) 
Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/391703 )

Change subject: Support consumption from multiple topics
..


Support consumption from multiple topics

This will allow for DC prefixed topics for statsv

Bug: T179093
Change-Id: I1ee995a5b22a84e5c84f356494c22df3a4b0e03e
---
M statsv.py
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  Ottomata: Verified



diff --git a/statsv.py b/statsv.py
index afe7e9a..627d79b 100644
--- a/statsv.py
+++ b/statsv.py
@@ -39,8 +39,8 @@
 description='statsv - consumes from varnishkafka Kafka topic and writes 
metrics to statsd'
 )
 ap.add_argument(
-'--topic',
-help='Kafka topic from which to consume.  Default: statsv',
+'--topics',
+help='Comma separated list of Kafka topics from which to consume.  
Default: statsv',
 default='statsv'
 )
 ap.add_argument(
@@ -110,7 +110,8 @@
 worker_count = args.workers
 
 kafka_bootstrap_servers = tuple(args.brokers.split(','))
-kafka_topic = args.topic
+kafka_topics = args.topics.split(',')
+
 kafka_consumer_group = args.consumer_group
 kafka_consumer_timeout_seconds = args.consumer_timeout_seconds
 
@@ -203,7 +204,7 @@
 
 # Create our Kafka Consumer instance.
 consumer = KafkaConsumer(
-kafka_topic,
+kafka_topics,
 bootstrap_servers=kafka_bootstrap_servers,
 group_id=kafka_consumer_group,
 auto_offset_reset='latest',

-- 
To view, visit https://gerrit.wikimedia.org/r/391703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1ee995a5b22a84e5c84f356494c22df3a4b0e03e
Gerrit-PatchSet: 1
Gerrit-Project: analytics/statsv
Gerrit-Branch: master
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/statsv[master]: Support consumption from multiple topics

2017-11-15 Thread Ottomata (Code Review) 
Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/391703 )

Change subject: Support consumption from multiple topics
..

Support consumption from multiple topics

This will allow for DC prefixed topics for statsv

Bug: T179093
Change-Id: I1ee995a5b22a84e5c84f356494c22df3a4b0e03e
---
M statsv.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/statsv 
refs/changes/03/391703/1

diff --git a/statsv.py b/statsv.py
index afe7e9a..627d79b 100644
--- a/statsv.py
+++ b/statsv.py
@@ -39,8 +39,8 @@
 description='statsv - consumes from varnishkafka Kafka topic and writes 
metrics to statsd'
 )
 ap.add_argument(
-'--topic',
-help='Kafka topic from which to consume.  Default: statsv',
+'--topics',
+help='Comma separated list of Kafka topics from which to consume.  
Default: statsv',
 default='statsv'
 )
 ap.add_argument(
@@ -110,7 +110,8 @@
 worker_count = args.workers
 
 kafka_bootstrap_servers = tuple(args.brokers.split(','))
-kafka_topic = args.topic
+kafka_topics = args.topics.split(',')
+
 kafka_consumer_group = args.consumer_group
 kafka_consumer_timeout_seconds = args.consumer_timeout_seconds
 
@@ -203,7 +204,7 @@
 
 # Create our Kafka Consumer instance.
 consumer = KafkaConsumer(
-kafka_topic,
+kafka_topics,
 bootstrap_servers=kafka_bootstrap_servers,
 group_id=kafka_consumer_group,
 auto_offset_reset='latest',

-- 
To view, visit https://gerrit.wikimedia.org/r/391703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ee995a5b22a84e5c84f356494c22df3a4b0e03e
Gerrit-PatchSet: 1
Gerrit-Project: analytics/statsv
Gerrit-Branch: master
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits