[MediaWiki-commits] [Gerrit] analytics/wikistats2[master]: Change addblocker text

2017-12-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398598 )

Change subject: Change addblocker text
..


Change addblocker text

We should probably fix at a later time the fact that
the addblocker text is on the app

Bug: T182958
Change-Id: Ia23b8a5266a62d4b25fc016c53e588db3cecc993
---
M src/App.vue
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Milimetric: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/App.vue b/src/App.vue
index cc0e4d9..9ac3c98 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -63,7 +63,7 @@
 },
 warnAdBlocker () {
 this.$store.state.centralNotice = {
-message: 'Your ad blocker is preventing Wikistats from 
reaching the server. Disable it to be able to see all metrics correctly.',
+message: 'Your ad blocker is preventing Wikistats from showing 
you metrics, because our API uses the word "pageview". There are no ads on any 
Wikimedia sites, but to see all metrics correctly you need to disable your ad 
blocker for this site.',
 level: 'error'
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/398598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23b8a5266a62d4b25fc016c53e588db3cecc993
Gerrit-PatchSet: 2
Gerrit-Project: analytics/wikistats2
Gerrit-Branch: master
Gerrit-Owner: Nuria 
Gerrit-Reviewer: Fdans 
Gerrit-Reviewer: Milimetric 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/wikistats2[master]: Change addblocker text

2017-12-15 Thread Nuria (Code Review) 
Nuria has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398598 )

Change subject: Change addblocker text
..

Change addblocker text

We should probably fix at a later time the fact that
the addblocker text is on the app

Bug: T182958
Change-Id: Ia23b8a5266a62d4b25fc016c53e588db3cecc993
---
M src/App.vue
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats2 
refs/changes/98/398598/1

diff --git a/src/App.vue b/src/App.vue
index cc0e4d9..bafab07 100644
--- a/src/App.vue
+++ b/src/App.vue
@@ -63,7 +63,7 @@
 },
 warnAdBlocker () {
 this.$store.state.centralNotice = {
-message: 'Your ad blocker is preventing Wikistats from 
reaching the server. Disable it to be able to see all metrics correctly.',
+message: 'Your ad blocker is preventing Wikistats\' scripts 
from reaching the server. Disable it to be able to see all metrics correctly. 
As on all Wikimedia services, we will not display ads. :)',
 level: 'error'
 }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/398598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia23b8a5266a62d4b25fc016c53e588db3cecc993
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikistats2
Gerrit-Branch: master
Gerrit-Owner: Nuria 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits