[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Description editing tutorial: further design tweaks

2017-01-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330722 )

Change subject: Description editing tutorial: further design tweaks
..


Description editing tutorial: further design tweaks

Moves the PageIndicatorView from the fragment layout to the view layout.
This has two benefits:

(1) we no longer require an offset that can potentially obscure text at
larger text size configurations;

(2) the page indicator view is included in the screenshots used for
testing.

Further tweaks the view layout to accommodate this new arrangement.

Sadly, this means that the page view indicator will no longer remain
stationary while scrolling between the pages but will appear separately
on each page; such is life.

Bug: T148205
Change-Id: Ic443210ef8a6512d19372eaef7a9c99e0a758f46
---
M app/src/main/res/layout/fragment_description_edit_tutorial.xml
M app/src/main/res/layout/view_description_edit_tutorial_page.xml
2 files changed, 50 insertions(+), 47 deletions(-)

Approvals:
  Niedzielski: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/res/layout/fragment_description_edit_tutorial.xml 
b/app/src/main/res/layout/fragment_description_edit_tutorial.xml
index 55cb467..59b4754 100644
--- a/app/src/main/res/layout/fragment_description_edit_tutorial.xml
+++ b/app/src/main/res/layout/fragment_description_edit_tutorial.xml
@@ -1,23 +1,6 @@
 
-http://schemas.android.com/apk/res/android;
-xmlns:attrs="http://schemas.android.com/apk/res-auto;
+http://schemas.android.com/apk/res/android;
+android:id="@+id/fragment_description_edit_tutorial_view_pager"
 android:layout_width="match_parent"
-android:layout_height="match_parent" >
-
-
-
-
-
-
\ No newline at end of file
+android:layout_height="match_parent" />
\ No newline at end of file
diff --git a/app/src/main/res/layout/view_description_edit_tutorial_page.xml 
b/app/src/main/res/layout/view_description_edit_tutorial_page.xml
index 0edf0b0..dcbf81d 100644
--- a/app/src/main/res/layout/view_description_edit_tutorial_page.xml
+++ b/app/src/main/res/layout/view_description_edit_tutorial_page.xml
@@ -1,6 +1,6 @@
 
-http://schemas.android.com/apk/res/android;
+http://schemas.android.com/apk/res/android;
+xmlns:app="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
 
tools:parentTag="org.wikipedia.descriptions.DescriptionEditTutorialPageView"
 tools:layout_width="match_parent"
@@ -19,32 +19,40 @@
 android:layout_height="0dp"
 android:layout_weight="50"
 android:orientation="vertical"
-android:paddingBottom="48dp"
 android:background="@color/light_blue"
-android:gravity="center">
+android:gravity="bottom|center_horizontal">
 
-
+
 
-
-
+
+
+
+
+
+
 
 
 
+
+
 
 
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/330722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic443210ef8a6512d19372eaef7a9c99e0a758f46
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Description editing tutorial: further design tweaks

2017-01-05 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330722 )

Change subject: Description editing tutorial: further design tweaks
..

Description editing tutorial: further design tweaks

Moves the PageIndicatorView from the fragment layout to the view layout.
This has two benefits:

(1) we no longer require an offset that can potentially obscure text at
larger text size configurations;

(2) the page indicator view is included in the screenshots used for
testing.

Further tweaks the view layout to accommodate this new arrangement.

Sadly, this means that the page view indicator will no longer remain
stationary while scrolling between the pages but will appear separately
on each page; such is life.

Bug: T148205
Change-Id: Ic443210ef8a6512d19372eaef7a9c99e0a758f46
---
M app/src/main/res/layout/fragment_description_edit_tutorial.xml
M app/src/main/res/layout/view_description_edit_tutorial_page.xml
2 files changed, 50 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/22/330722/1

diff --git a/app/src/main/res/layout/fragment_description_edit_tutorial.xml 
b/app/src/main/res/layout/fragment_description_edit_tutorial.xml
index 55cb467..59b4754 100644
--- a/app/src/main/res/layout/fragment_description_edit_tutorial.xml
+++ b/app/src/main/res/layout/fragment_description_edit_tutorial.xml
@@ -1,23 +1,6 @@
 
-http://schemas.android.com/apk/res/android;
-xmlns:attrs="http://schemas.android.com/apk/res-auto;
+http://schemas.android.com/apk/res/android;
+android:id="@+id/fragment_description_edit_tutorial_view_pager"
 android:layout_width="match_parent"
-android:layout_height="match_parent" >
-
-
-
-
-
-
\ No newline at end of file
+android:layout_height="match_parent" />
\ No newline at end of file
diff --git a/app/src/main/res/layout/view_description_edit_tutorial_page.xml 
b/app/src/main/res/layout/view_description_edit_tutorial_page.xml
index 0edf0b0..5da7260 100644
--- a/app/src/main/res/layout/view_description_edit_tutorial_page.xml
+++ b/app/src/main/res/layout/view_description_edit_tutorial_page.xml
@@ -1,6 +1,6 @@
 
-http://schemas.android.com/apk/res/android;
+http://schemas.android.com/apk/res/android;
+xmlns:attrs="http://schemas.android.com/apk/res-auto;
 xmlns:tools="http://schemas.android.com/tools;
 
tools:parentTag="org.wikipedia.descriptions.DescriptionEditTutorialPageView"
 tools:layout_width="match_parent"
@@ -19,32 +19,40 @@
 android:layout_height="0dp"
 android:layout_weight="50"
 android:orientation="vertical"
-android:paddingBottom="48dp"
 android:background="@color/light_blue"
-android:gravity="center">
+android:gravity="bottom|center_horizontal">
 
-
+
 
-
-
+
+
+
+
+
+
 
 
 
+
+
 
 
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/330722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic443210ef8a6512d19372eaef7a9c99e0a758f46
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits