[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: no longer draw rectangular border around list ...
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/380845 ) Change subject: Design tweak: no longer draw rectangular border around list item images. .. Design tweak: no longer draw rectangular border around list item images. Per https://phabricator.wikimedia.org/T163590#3561236 Change-Id: I1478afbd11493bb0339b574fad7fda39d91b1ee5 --- D app/src/main/res/drawable/view_list_card_item_image_background.xml M app/src/main/res/layout/dialog_link_preview.xml M app/src/main/res/layout/item_page_list_entry.xml M app/src/main/res/layout/item_search_result.xml M app/src/main/res/layout/view_list_card_item.xml 5 files changed, 4 insertions(+), 10 deletions(-) Approvals: jenkins-bot: Verified Mholloway: Looks good to me, approved diff --git a/app/src/main/res/drawable/view_list_card_item_image_background.xml b/app/src/main/res/drawable/view_list_card_item_image_background.xml deleted file mode 100644 index d6df27a..000 --- a/app/src/main/res/drawable/view_list_card_item_image_background.xml +++ /dev/null @@ -1,6 +0,0 @@ - -http://schemas.android.com/apk/res/android";> - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/dialog_link_preview.xml b/app/src/main/res/layout/dialog_link_preview.xml index 5277fc7..01af4c3 100755 --- a/app/src/main/res/layout/dialog_link_preview.xml +++ b/app/src/main/res/layout/dialog_link_preview.xml @@ -33,7 +33,7 @@ android:layout_margin="16dp" android:layout_gravity="center_vertical" android:contentDescription="@null" - app:backgroundImage="@drawable/view_list_card_item_image_background"/> +app:backgroundImage="?attr/paper_color"/> +app:backgroundImage="?attr/paper_color" /> http://schemas.android.com/apk/res-auto"; diff --git a/app/src/main/res/layout/item_search_result.xml b/app/src/main/res/layout/item_search_result.xml index f9d7380..fc974c3 100644 --- a/app/src/main/res/layout/item_search_result.xml +++ b/app/src/main/res/layout/item_search_result.xml @@ -22,7 +22,7 @@ android:layout_height="@dimen/view_list_card_item_image" android:layout_marginTop="6dp" app:roundedCornerRadius="2dp" -app:backgroundImage="@drawable/view_list_card_item_image_background" /> +app:backgroundImage="?attr/paper_color" /> +app:backgroundImage="?attr/paper_color" /> https://gerrit.wikimedia.org/r/380845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1478afbd11493bb0339b574fad7fda39d91b1ee5 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Cooltey Gerrit-Reviewer: Mholloway Gerrit-Reviewer: Sharvaniharan Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: no longer draw rectangular border around list ...
Dbrant has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380845 ) Change subject: Design tweak: no longer draw rectangular border around list item images. .. Design tweak: no longer draw rectangular border around list item images. Per https://phabricator.wikimedia.org/T163590#3561236 Change-Id: I1478afbd11493bb0339b574fad7fda39d91b1ee5 --- D app/src/main/res/drawable/view_list_card_item_image_background.xml M app/src/main/res/layout/dialog_link_preview.xml M app/src/main/res/layout/item_page_list_entry.xml M app/src/main/res/layout/item_search_result.xml M app/src/main/res/layout/view_list_card_item.xml 5 files changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/45/380845/1 diff --git a/app/src/main/res/drawable/view_list_card_item_image_background.xml b/app/src/main/res/drawable/view_list_card_item_image_background.xml deleted file mode 100644 index d6df27a..000 --- a/app/src/main/res/drawable/view_list_card_item_image_background.xml +++ /dev/null @@ -1,6 +0,0 @@ - -http://schemas.android.com/apk/res/android";> - - - - \ No newline at end of file diff --git a/app/src/main/res/layout/dialog_link_preview.xml b/app/src/main/res/layout/dialog_link_preview.xml index 5277fc7..01af4c3 100755 --- a/app/src/main/res/layout/dialog_link_preview.xml +++ b/app/src/main/res/layout/dialog_link_preview.xml @@ -33,7 +33,7 @@ android:layout_margin="16dp" android:layout_gravity="center_vertical" android:contentDescription="@null" - app:backgroundImage="@drawable/view_list_card_item_image_background"/> +app:backgroundImage="?attr/paper_color"/> +app:backgroundImage="?attr/paper_color" /> http://schemas.android.com/apk/res-auto"; diff --git a/app/src/main/res/layout/item_search_result.xml b/app/src/main/res/layout/item_search_result.xml index f9d7380..fc974c3 100644 --- a/app/src/main/res/layout/item_search_result.xml +++ b/app/src/main/res/layout/item_search_result.xml @@ -22,7 +22,7 @@ android:layout_height="@dimen/view_list_card_item_image" android:layout_marginTop="6dp" app:roundedCornerRadius="2dp" -app:backgroundImage="@drawable/view_list_card_item_image_background" /> +app:backgroundImage="?attr/paper_color" /> +app:backgroundImage="?attr/paper_color" /> https://gerrit.wikimedia.org/r/380845 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1478afbd11493bb0339b574fad7fda39d91b1ee5 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
