[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: update header edit button tint
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377353 ) Change subject: Design tweak: update header edit button tint .. Design tweak: update header edit button tint Bug: T172157 Change-Id: Id27761669b9aad340b0e83e94d7600cd85dd7d69 --- M app/src/main/res/layout/view_page_header.xml M app/src/main/res/values/attrs.xml M app/src/main/res/values/styles_dark.xml M app/src/main/res/values/styles_light.xml 4 files changed, 5 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/src/main/res/layout/view_page_header.xml b/app/src/main/res/layout/view_page_header.xml index 45a046f..1a0eb99 100644 --- a/app/src/main/res/layout/view_page_header.xml +++ b/app/src/main/res/layout/view_page_header.xml @@ -73,7 +73,8 @@ android:layout_gravity="bottom|end" app:srcCompat="@drawable/ic_mode_edit_white_24dp" android:scaleType="fitCenter" -android:tint="?attr/page_description_color" +android:tint="?android:attr/textColorSecondary" +android:alpha="?attr/page_header_edit_pencil_alpha" android:background="?attr/selectableItemBackgroundBorderless" android:contentDescription="@string/article_header_edit_hint" /> diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 7334067..45e1c59 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -35,6 +35,7 @@ + diff --git a/app/src/main/res/values/styles_dark.xml b/app/src/main/res/values/styles_dark.xml index c92bd78..aa6976c 100644 --- a/app/src/main/res/values/styles_dark.xml +++ b/app/src/main/res/values/styles_dark.xml @@ -58,6 +58,7 @@ @color/link_preview_offline_text_dark @color/list_item_text_primary_dark @color/list_item_text_secondary_dark +1.0 @color/offline_library_background_color_dark diff --git a/app/src/main/res/values/styles_light.xml b/app/src/main/res/values/styles_light.xml index 56c14a9..17d63d2 100644 --- a/app/src/main/res/values/styles_light.xml +++ b/app/src/main/res/values/styles_light.xml @@ -58,6 +58,7 @@ @color/link_preview_offline_text_light @color/list_item_text_primary_light @color/list_item_text_secondary_light +0.55 @color/offline_library_background_color_light -- To view, visit https://gerrit.wikimedia.org/r/377353 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27761669b9aad340b0e83e94d7600cd85dd7d69 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway Gerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Cooltey Gerrit-Reviewer: Dbrant Gerrit-Reviewer: Sharvaniharan Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Design tweak: update header edit button tint
Mholloway has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377353 ) Change subject: Design tweak: update header edit button tint .. Design tweak: update header edit button tint Bug: T172157 Change-Id: Id27761669b9aad340b0e83e94d7600cd85dd7d69 --- M app/src/main/res/layout/view_page_header.xml M app/src/main/res/values/attrs.xml M app/src/main/res/values/styles_dark.xml M app/src/main/res/values/styles_light.xml 4 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/53/377353/1 diff --git a/app/src/main/res/layout/view_page_header.xml b/app/src/main/res/layout/view_page_header.xml index 45a046f..1a0eb99 100644 --- a/app/src/main/res/layout/view_page_header.xml +++ b/app/src/main/res/layout/view_page_header.xml @@ -73,7 +73,8 @@ android:layout_gravity="bottom|end" app:srcCompat="@drawable/ic_mode_edit_white_24dp" android:scaleType="fitCenter" -android:tint="?attr/page_description_color" +android:tint="?android:attr/textColorSecondary" +android:alpha="?attr/page_header_edit_pencil_alpha" android:background="?attr/selectableItemBackgroundBorderless" android:contentDescription="@string/article_header_edit_hint" /> diff --git a/app/src/main/res/values/attrs.xml b/app/src/main/res/values/attrs.xml index 7334067..45e1c59 100644 --- a/app/src/main/res/values/attrs.xml +++ b/app/src/main/res/values/attrs.xml @@ -35,6 +35,7 @@ + diff --git a/app/src/main/res/values/styles_dark.xml b/app/src/main/res/values/styles_dark.xml index c92bd78..aa6976c 100644 --- a/app/src/main/res/values/styles_dark.xml +++ b/app/src/main/res/values/styles_dark.xml @@ -58,6 +58,7 @@ @color/link_preview_offline_text_dark @color/list_item_text_primary_dark @color/list_item_text_secondary_dark +1.0 @color/offline_library_background_color_dark diff --git a/app/src/main/res/values/styles_light.xml b/app/src/main/res/values/styles_light.xml index 56c14a9..17d63d2 100644 --- a/app/src/main/res/values/styles_light.xml +++ b/app/src/main/res/values/styles_light.xml @@ -58,6 +58,7 @@ @color/link_preview_offline_text_light @color/list_item_text_primary_light @color/list_item_text_secondary_light +0.55 @color/offline_library_background_color_light -- To view, visit https://gerrit.wikimedia.org/r/377353 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id27761669b9aad340b0e83e94d7600cd85dd7d69 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
