[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: Remove redundant ANDROID_HOME setting
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/368240 ) Change subject: Hygiene: Remove redundant ANDROID_HOME setting .. Hygiene: Remove redundant ANDROID_HOME setting SDK installation is managed by the Jenkins emulator plugin for our periodic job, which uses it; no need to set it here. Change-Id: I134dd00a76c09b559c6f333bddfde66482166abb --- M scripts/apps-android-wikipedia-periodic-test 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Mholloway: Looks good to me, approved diff --git a/scripts/apps-android-wikipedia-periodic-test b/scripts/apps-android-wikipedia-periodic-test index d858135..56aa758 100755 --- a/scripts/apps-android-wikipedia-periodic-test +++ b/scripts/apps-android-wikipedia-periodic-test @@ -1,8 +1,6 @@ #!/usr/bin/env bash set -euo pipefail -export ANDROID_HOME="${ANDROID_HOME:-$PWD/.sdk}" - ./gradlew clean checkstyle lintAlphaRelease testAllAlphaRelease scripts/diff-screenshots \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/368240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I134dd00a76c09b559c6f333bddfde66482166abb Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: MhollowayGerrit-Reviewer: Brion VIBBER Gerrit-Reviewer: Dbrant Gerrit-Reviewer: Mholloway Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: Remove redundant ANDROID_HOME setting
Mholloway has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368240 ) Change subject: Hygiene: Remove redundant ANDROID_HOME setting .. Hygiene: Remove redundant ANDROID_HOME setting SDK installation is managed by the Jenkins emulator plugin for our periodic job, which uses it; no need to set it here. Change-Id: I134dd00a76c09b559c6f333bddfde66482166abb --- M scripts/apps-android-wikipedia-periodic-test 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/40/368240/1 diff --git a/scripts/apps-android-wikipedia-periodic-test b/scripts/apps-android-wikipedia-periodic-test index d858135..56aa758 100755 --- a/scripts/apps-android-wikipedia-periodic-test +++ b/scripts/apps-android-wikipedia-periodic-test @@ -1,8 +1,6 @@ #!/usr/bin/env bash set -euo pipefail -export ANDROID_HOME="${ANDROID_HOME:-$PWD/.sdk}" - ./gradlew clean checkstyle lintAlphaRelease testAllAlphaRelease scripts/diff-screenshots \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/368240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I134dd00a76c09b559c6f333bddfde66482166abb Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits