[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: Update test script comments

2017-10-23 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/386099 )

Change subject: Hygiene: Update test script comments
..


Hygiene: Update test script comments

Change-Id: I9cc9bc44b4a6a041975c5724b2599c9cdbfb47fd
---
M scripts/apps-android-wikipedia-publish
M scripts/apps-android-wikipedia-test
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Cooltey: Looks good to me, approved



diff --git a/scripts/apps-android-wikipedia-publish 
b/scripts/apps-android-wikipedia-publish
index d364a34..721a72b 100755
--- a/scripts/apps-android-wikipedia-publish
+++ b/scripts/apps-android-wikipedia-publish
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# For use with Jenkins CI, pass the Android SDK location as an argument:
+# Optionally pass an Android SDK location as an argument:
 # $ apps-android-wikipedia-publish /srv/jenkins-workspace/tools/android-sdk
 if [ ! $# -eq 0 ]; then
   echo "org.gradle.jvmargs=-Xmx1536M" >> gradle.properties
diff --git a/scripts/apps-android-wikipedia-test 
b/scripts/apps-android-wikipedia-test
index 4aca812..0feba95 100755
--- a/scripts/apps-android-wikipedia-test
+++ b/scripts/apps-android-wikipedia-test
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# For use with Jenkins CI, pass the Android SDK location as an argument:
+# Optionally pass an Android SDK location as an argument:
 # $ apps-android-wikipedia-test /srv/jenkins-workspace/tools/android-sdk
 if [ ! $# -eq 0 ]; then
   echo "org.gradle.jvmargs=-Xmx1536M" >> gradle.properties

-- 
To view, visit https://gerrit.wikimedia.org/r/386099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cc9bc44b4a6a041975c5724b2599c9cdbfb47fd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Cooltey 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Sharvaniharan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: Update test script comments

2017-10-23 Thread Mholloway (Code Review)
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/386099 )

Change subject: Hygiene: Update test script comments
..

Hygiene: Update test script comments

Change-Id: I9cc9bc44b4a6a041975c5724b2599c9cdbfb47fd
---
M scripts/apps-android-wikipedia-publish
M scripts/apps-android-wikipedia-test
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/99/386099/1

diff --git a/scripts/apps-android-wikipedia-publish 
b/scripts/apps-android-wikipedia-publish
index d364a34..721a72b 100755
--- a/scripts/apps-android-wikipedia-publish
+++ b/scripts/apps-android-wikipedia-publish
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# For use with Jenkins CI, pass the Android SDK location as an argument:
+# Optionally pass an Android SDK location as an argument:
 # $ apps-android-wikipedia-publish /srv/jenkins-workspace/tools/android-sdk
 if [ ! $# -eq 0 ]; then
   echo "org.gradle.jvmargs=-Xmx1536M" >> gradle.properties
diff --git a/scripts/apps-android-wikipedia-test 
b/scripts/apps-android-wikipedia-test
index 4aca812..0feba95 100755
--- a/scripts/apps-android-wikipedia-test
+++ b/scripts/apps-android-wikipedia-test
@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-# For use with Jenkins CI, pass the Android SDK location as an argument:
+# Optionally pass an Android SDK location as an argument:
 # $ apps-android-wikipedia-test /srv/jenkins-workspace/tools/android-sdk
 if [ ! $# -eq 0 ]; then
   echo "org.gradle.jvmargs=-Xmx1536M" >> gradle.properties

-- 
To view, visit https://gerrit.wikimedia.org/r/386099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cc9bc44b4a6a041975c5724b2599c9cdbfb47fd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits