[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove duplicate method in WidgetProviderFeaturedPage

2017-03-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/340563 )

Change subject: Hygiene: remove duplicate method in WidgetProviderFeaturedPage
..


Hygiene: remove duplicate method in WidgetProviderFeaturedPage

Bug: T156917
Change-Id: Ifd56396118d2103635a58ed81bee622cc3e6c9ef
---
M app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git 
a/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java 
b/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
index f991505..7ca5dc6 100644
--- a/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
+++ b/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
@@ -6,7 +6,6 @@
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
-import android.content.res.Resources;
 import android.text.Spanned;
 import android.text.TextUtils;
 import android.text.style.URLSpan;
@@ -76,7 +75,7 @@
 MainPageNameData.valueFor(app.getAppOrSystemLanguageCode()),
 app.getWikiSite());
 
-getApiService(title).pageLead(title.getPrefixedText(), 
calculateLeadImageWidth(),
+getApiService(title).pageLead(title.getPrefixedText(), 
DimenUtil.calculateLeadImageWidth(),
 !app.isImageDownloadEnabled(), new PageLead.Callback() {
 @Override
 public void success(PageLead pageLead) {
@@ -119,11 +118,6 @@
 }
 }
 return titleText;
-}
-
-private int calculateLeadImageWidth() {
-Resources res = WikipediaApp.getInstance().getResources();
-return (int) (res.getDimension(R.dimen.leadImageWidth) / 
DimenUtil.getDensityScalar());
 }
 
 private PageService getApiService(PageTitle title) {

-- 
To view, visit https://gerrit.wikimedia.org/r/340563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd56396118d2103635a58ed81bee622cc3e6c9ef
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Sniedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove duplicate method in WidgetProviderFeaturedPage

2017-03-01 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/340563 )

Change subject: Hygiene: remove duplicate method in WidgetProviderFeaturedPage
..

Hygiene: remove duplicate method in WidgetProviderFeaturedPage

Bug: T156917
Change-Id: Ifd56396118d2103635a58ed81bee622cc3e6c9ef
---
M app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/63/340563/1

diff --git 
a/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java 
b/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
index f991505..7ca5dc6 100644
--- a/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
+++ b/app/src/main/java/org/wikipedia/widgets/WidgetProviderFeaturedPage.java
@@ -6,7 +6,6 @@
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
-import android.content.res.Resources;
 import android.text.Spanned;
 import android.text.TextUtils;
 import android.text.style.URLSpan;
@@ -76,7 +75,7 @@
 MainPageNameData.valueFor(app.getAppOrSystemLanguageCode()),
 app.getWikiSite());
 
-getApiService(title).pageLead(title.getPrefixedText(), 
calculateLeadImageWidth(),
+getApiService(title).pageLead(title.getPrefixedText(), 
DimenUtil.calculateLeadImageWidth(),
 !app.isImageDownloadEnabled(), new PageLead.Callback() {
 @Override
 public void success(PageLead pageLead) {
@@ -119,11 +118,6 @@
 }
 }
 return titleText;
-}
-
-private int calculateLeadImageWidth() {
-Resources res = WikipediaApp.getInstance().getResources();
-return (int) (res.getDimension(R.dimen.leadImageWidth) / 
DimenUtil.getDensityScalar());
 }
 
 private PageService getApiService(PageTitle title) {

-- 
To view, visit https://gerrit.wikimedia.org/r/340563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd56396118d2103635a58ed81bee622cc3e6c9ef
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits