[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove redundant code in NavTabView/Test
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: remove redundant code in NavTabView/Test .. Hygiene: remove redundant code in NavTabView/Test • Remove redundant Drawable padding change. It's unclear why but the screenshots showed the slightest jitter seemingly from this change so update them too. • Remove screen width as a variable for layout direction. NavTabView is no longer responsive. Change-Id: I00183908177674f65250ba77e9fe95f3c05cad07 --- M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png D app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png D app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testTheme-120dp-en-ltr-font1.0x-dark.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testTheme-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-120dp-en-ltr-font1.5x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-720dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-720dp-en-ltr-font1.5x-light.png M app/src/androidTest/java/org/wikipedia/navtab/NavTabViewTest.java M app/src/main/java/org/wikipedia/navtab/NavTabView.java 14 files changed, 2 insertions(+), 4 deletions(-) Approvals: BearND: Looks good to me, approved jenkins-bot: Verified diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png index 51239fc..fea2bbe 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png index 51239fc..fea2bbe 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png deleted file mode 100644 index 3b4108c..000 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png +++ /dev/null Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png deleted file mode 100644 index 3b4108c..000 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png +++ /dev/null Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png index a21d028..c085dc5 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png index a21d028..c085dc5 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png Binary files differ diff --git
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove redundant code in NavTabView/Test
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/310585 Change subject: Hygiene: remove redundant code in NavTabView/Test .. Hygiene: remove redundant code in NavTabView/Test • Remove redundant Drawable padding change. It's unclear why but the screenshots showed the slightest jitter seemingly from this change so update them too. • Remove screen width as a variable for layout direction. NavTabView is no longer responsive. Change-Id: I00183908177674f65250ba77e9fe95f3c05cad07 --- M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png D app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png D app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testTheme-120dp-en-ltr-font1.0x-dark.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testTheme-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-120dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-120dp-en-ltr-font1.5x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-720dp-en-ltr-font1.0x-light.png M app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testWidth-720dp-en-ltr-font1.5x-light.png M app/src/androidTest/java/org/wikipedia/navtab/NavTabViewTest.java M app/src/main/java/org/wikipedia/navtab/NavTabView.java 14 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/85/310585/1 diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png index 51239fc..fea2bbe 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-ltr-font1.0x-light.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png index 51239fc..fea2bbe 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-120dp-en-rtl-font1.0x-light.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png deleted file mode 100644 index 3b4108c..000 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-ltr-font1.0x-light.png +++ /dev/null Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png deleted file mode 100644 index 3b4108c..000 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testLayoutDirection-480dp-en-rtl-font1.0x-light.png +++ /dev/null Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png index a21d028..c085dc5 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-dark.png Binary files differ diff --git a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png index a21d028..c085dc5 100644 --- a/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png +++ b/app/screenshots-ref/org.wikipedia.navtab.NavTabViewTest.testSelect-120dp-en-ltr-font1.0x-light.png Binary files differ diff --git
