[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unnecessary View casts.
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/384160 )
Change subject: Hygiene: remove unnecessary View casts.
..
Hygiene: remove unnecessary View casts.
Change-Id: I907965ce6ad7b13b7cc53abcd5bc4dde9bb143fe
---
M app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
M app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
M app/src/main/java/org/wikipedia/edit/preview/EditPreviewFragment.java
M app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
M app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
M app/src/main/java/org/wikipedia/gallery/GalleryItemFragment.java
M app/src/main/java/org/wikipedia/gallery/GalleryThumbnailScrollView.java
M app/src/main/java/org/wikipedia/history/SearchActionModeCallback.java
M app/src/main/java/org/wikipedia/language/LangLinksActivity.java
M app/src/main/java/org/wikipedia/page/DisambigListAdapter.java
M app/src/main/java/org/wikipedia/page/FindInPageActionProvider.java
M app/src/main/java/org/wikipedia/page/IssuesListAdapter.java
M app/src/main/java/org/wikipedia/page/NoDimBottomSheetDialog.java
M app/src/main/java/org/wikipedia/page/PageFragment.java
M app/src/main/java/org/wikipedia/page/PageInfoDialog.java
M app/src/main/java/org/wikipedia/page/ReferenceDialog.java
M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
M app/src/main/java/org/wikipedia/page/shareafact/ShareHandler.java
M app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
M app/src/main/java/org/wikipedia/readinglist/AddToReadingListDialog.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
M app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
M app/src/main/java/org/wikipedia/search/SearchFragment.java
M app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
M app/src/main/java/org/wikipedia/settings/AboutActivity.java
M app/src/main/java/org/wikipedia/settings/LanguagePreferenceDialog.java
M app/src/main/java/org/wikipedia/settings/LicenseActivity.java
M app/src/main/java/org/wikipedia/util/FeedbackUtil.java
M app/src/main/java/org/wikipedia/views/TextInputDialog.java
M app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java
31 files changed, 93 insertions(+), 94 deletions(-)
Approvals:
jenkins-bot: Verified
Cooltey: Looks good to me, approved
diff --git a/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
b/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
index 5587857..7553fb2 100644
--- a/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
+++ b/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
@@ -49,10 +49,10 @@
this.prevTitle = prevTitle;
captchaContainer = activity.findViewById(R.id.captcha_container);
-captchaImage = (SimpleDraweeView)
activity.findViewById(R.id.captcha_image);
+captchaImage = activity.findViewById(R.id.captcha_image);
captchaText = ((TextInputLayout)
activity.findViewById(R.id.captcha_text)).getEditText();
captchaProgress = activity.findViewById(R.id.captcha_image_progress);
-TextView submitButton = (TextView)
activity.findViewById(R.id.captcha_submit_button);
+TextView submitButton =
activity.findViewById(R.id.captcha_submit_button);
if (submitButtonText != null) {
submitButton.setText(submitButtonText);
diff --git a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
index b300d54..a78878f 100644
--- a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
+++ b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
@@ -148,19 +148,19 @@
supportActionBar.setTitle("");
}
-sectionText = (EditText) findViewById(R.id.edit_section_text);
+sectionText = findViewById(R.id.edit_section_text);
syntaxHighlighter = new SyntaxHighlighter(this, sectionText);
sectionProgress = findViewById(R.id.edit_section_load_progress);
-sectionContainer = (ScrollView)
findViewById(R.id.edit_section_container);
+sectionContainer = findViewById(R.id.edit_section_container);
sectionContainer.setSmoothScrollingEnabled(false);
-errorView = (WikiErrorView) findViewById(R.id.view_edit_section_error);
+errorView = findViewById(R.id.view_edit_section_error);
abusefilterContainer =
findViewById(R.id.edit_section_abusefilter_container);
-abuseFilterImage = (ImageView)
findViewById(R.id.edit_section_abusefilter_image);
-abusefilterTitle = (TextView)
findViewById(R.id.edit_section_abusefilter_title);
-abusefilterText = (TextView)
findViewById(R.id.edit_section_abusefilter_text);
+abuseFilterImage = findViewById(R.id.e
[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unnecessary View casts.
Dbrant has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/384160 )
Change subject: Hygiene: remove unnecessary View casts.
..
Hygiene: remove unnecessary View casts.
Change-Id: I907965ce6ad7b13b7cc53abcd5bc4dde9bb143fe
---
M app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
M app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
M app/src/main/java/org/wikipedia/edit/preview/EditPreviewFragment.java
M app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
M app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
M app/src/main/java/org/wikipedia/gallery/GalleryItemFragment.java
M app/src/main/java/org/wikipedia/gallery/GalleryThumbnailScrollView.java
M app/src/main/java/org/wikipedia/history/SearchActionModeCallback.java
M app/src/main/java/org/wikipedia/language/LangLinksActivity.java
M app/src/main/java/org/wikipedia/page/DisambigListAdapter.java
M app/src/main/java/org/wikipedia/page/FindInPageActionProvider.java
M app/src/main/java/org/wikipedia/page/IssuesListAdapter.java
M app/src/main/java/org/wikipedia/page/NoDimBottomSheetDialog.java
M app/src/main/java/org/wikipedia/page/PageFragment.java
M app/src/main/java/org/wikipedia/page/PageInfoDialog.java
M app/src/main/java/org/wikipedia/page/ReferenceDialog.java
M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
M app/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
M app/src/main/java/org/wikipedia/page/shareafact/ShareHandler.java
M app/src/main/java/org/wikipedia/page/tabs/TabsProvider.java
M app/src/main/java/org/wikipedia/readinglist/AddToReadingListDialog.java
M app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
M app/src/main/java/org/wikipedia/search/RecentSearchesFragment.java
M app/src/main/java/org/wikipedia/search/SearchFragment.java
M app/src/main/java/org/wikipedia/search/SearchResultsFragment.java
M app/src/main/java/org/wikipedia/settings/AboutActivity.java
M app/src/main/java/org/wikipedia/settings/LanguagePreferenceDialog.java
M app/src/main/java/org/wikipedia/settings/LicenseActivity.java
M app/src/main/java/org/wikipedia/util/FeedbackUtil.java
M app/src/main/java/org/wikipedia/views/TextInputDialog.java
M app/src/main/java/org/wikipedia/wiktionary/WiktionaryDialog.java
31 files changed, 93 insertions(+), 94 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/60/384160/1
diff --git a/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
b/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
index 5587857..7553fb2 100644
--- a/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
+++ b/app/src/main/java/org/wikipedia/captcha/CaptchaHandler.java
@@ -49,10 +49,10 @@
this.prevTitle = prevTitle;
captchaContainer = activity.findViewById(R.id.captcha_container);
-captchaImage = (SimpleDraweeView)
activity.findViewById(R.id.captcha_image);
+captchaImage = activity.findViewById(R.id.captcha_image);
captchaText = ((TextInputLayout)
activity.findViewById(R.id.captcha_text)).getEditText();
captchaProgress = activity.findViewById(R.id.captcha_image_progress);
-TextView submitButton = (TextView)
activity.findViewById(R.id.captcha_submit_button);
+TextView submitButton =
activity.findViewById(R.id.captcha_submit_button);
if (submitButtonText != null) {
submitButton.setText(submitButtonText);
diff --git a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
index b300d54..a78878f 100644
--- a/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
+++ b/app/src/main/java/org/wikipedia/edit/EditSectionActivity.java
@@ -148,19 +148,19 @@
supportActionBar.setTitle("");
}
-sectionText = (EditText) findViewById(R.id.edit_section_text);
+sectionText = findViewById(R.id.edit_section_text);
syntaxHighlighter = new SyntaxHighlighter(this, sectionText);
sectionProgress = findViewById(R.id.edit_section_load_progress);
-sectionContainer = (ScrollView)
findViewById(R.id.edit_section_container);
+sectionContainer = findViewById(R.id.edit_section_container);
sectionContainer.setSmoothScrollingEnabled(false);
-errorView = (WikiErrorView) findViewById(R.id.view_edit_section_error);
+errorView = findViewById(R.id.view_edit_section_error);
abusefilterContainer =
findViewById(R.id.edit_section_abusefilter_container);
-abuseFilterImage = (ImageView)
findViewById(R.id.edit_section_abusefilter_image);
-abusefilterTitle = (TextView)
findViewById(R.id.edit_section_abusefilter_title);
-abusefilterText = (TextView)
findViewById(R.id.edit_section_abusefilter_text);
+abuseFilterImage = findViewById(
