[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: use @BindView for SearchFragment View

2016-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: use @BindView for SearchFragment View
..


Hygiene: use @BindView for SearchFragment View

Change-Id: If395bfe424376385633b17fcea91c5693dac2b05
---
M app/src/main/java/org/wikipedia/search/SearchFragment.java
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/src/main/java/org/wikipedia/search/SearchFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchFragment.java
index 99689df..a769274 100644
--- a/app/src/main/java/org/wikipedia/search/SearchFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchFragment.java
@@ -98,14 +98,14 @@
 private Unbinder unbinder;
 
 private WikipediaApp app;
-private EditText searchEditText;
+@BindView(android.support.v7.appcompat.R.id.search_src_text) EditText 
searchEditText;
 private SearchFunnel funnel;
 private InvokeSource invokeSource = InvokeSource.TOOLBAR;
 
 /**
  * Whether the Search fragment is currently showing.
  */
-private boolean isSearchActive = false;
+private boolean isSearchActive;
 
 /**
  * The last search term that the user entered. This will be passed into
@@ -354,8 +354,6 @@
 searchView.setOnQueryTextListener(searchQueryListener);
 searchView.setOnCloseListener(searchCloseListener);
 
-searchEditText = (EditText) searchView
-
.findViewById(android.support.v7.appcompat.R.id.search_src_text);
 // reset its background
 searchEditText.setBackgroundColor(Color.TRANSPARENT);
 // make the search frame match_parent

-- 
To view, visit https://gerrit.wikimedia.org/r/310966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If395bfe424376385633b17fcea91c5693dac2b05
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: use @BindView for SearchFragment View

2016-09-15 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310966

Change subject: Hygiene: use @BindView for SearchFragment View
..

Hygiene: use @BindView for SearchFragment View

Change-Id: If395bfe424376385633b17fcea91c5693dac2b05
---
M app/src/main/java/org/wikipedia/search/SearchFragment.java
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/66/310966/1

diff --git a/app/src/main/java/org/wikipedia/search/SearchFragment.java 
b/app/src/main/java/org/wikipedia/search/SearchFragment.java
index 99689df..a769274 100644
--- a/app/src/main/java/org/wikipedia/search/SearchFragment.java
+++ b/app/src/main/java/org/wikipedia/search/SearchFragment.java
@@ -98,14 +98,14 @@
 private Unbinder unbinder;
 
 private WikipediaApp app;
-private EditText searchEditText;
+@BindView(android.support.v7.appcompat.R.id.search_src_text) EditText 
searchEditText;
 private SearchFunnel funnel;
 private InvokeSource invokeSource = InvokeSource.TOOLBAR;
 
 /**
  * Whether the Search fragment is currently showing.
  */
-private boolean isSearchActive = false;
+private boolean isSearchActive;
 
 /**
  * The last search term that the user entered. This will be passed into
@@ -354,8 +354,6 @@
 searchView.setOnQueryTextListener(searchQueryListener);
 searchView.setOnCloseListener(searchCloseListener);
 
-searchEditText = (EditText) searchView
-
.findViewById(android.support.v7.appcompat.R.id.search_src_text);
 // reset its background
 searchEditText.setBackgroundColor(Color.TRANSPARENT);
 // make the search frame match_parent

-- 
To view, visit https://gerrit.wikimedia.org/r/310966
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If395bfe424376385633b17fcea91c5693dac2b05
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits