[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update Retrofit to 2.3.0

2017-06-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/358146 )

Change subject: Update Retrofit to 2.3.0
..


Update Retrofit to 2.3.0

Possibly of note:

* New: String converters that return null for an @Query or @Field parameter
  are now skipped.

Also includes a bunch of improvements around RxJava support, which might
become interesting to us at some point.

https://github.com/square/retrofit/blob/master/CHANGELOG.md

Change-Id: I07b9af6f451de8b4b3c2008c39f5bf8a2e198eab
---
M app/build.gradle
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Niedzielski: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app/build.gradle b/app/build.gradle
index cdf147b..25c3ed1 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -164,7 +164,7 @@
 
 String okHttpVersion = '3.8.0' // When updating this version, resync file 
copies under
// app/src/main/java/okhttp3
-String retrofitVersion = '2.2.0'
+String retrofitVersion = '2.3.0'
 String supportVersion = '25.4.0'
 String espressoVersion = '2.2.2'
 String butterKnifeVersion = '8.5.1'

-- 
To view, visit https://gerrit.wikimedia.org/r/358146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07b9af6f451de8b4b3c2008c39f5bf8a2e198eab
Gerrit-PatchSet: 4
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Sniedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update Retrofit to 2.3.0

2017-06-09 Thread Mholloway (Code Review) 
Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/358146 )

Change subject: Update Retrofit to 2.3.0
..

Update Retrofit to 2.3.0

Possibly of note:

* New: String converters that return null for an @Query or @Field parameter
  are now skipped.

Also includes a bunch of improvements around RxJava support, which might
become interesting to us at some point.

Change-Id: I07b9af6f451de8b4b3c2008c39f5bf8a2e198eab
---
M app/build.gradle
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/46/358146/1

diff --git a/app/build.gradle b/app/build.gradle
index ccc4796..1423750 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -164,7 +164,7 @@
 
 String okHttpVersion = '3.8.0' // When updating this version, resync file 
copies under
// app/src/main/java/okhttp3
-String retrofitVersion = '2.2.0'
+String retrofitVersion = '2.3.0'
 String supportVersion = '25.3.1'
 String espressoVersion = '2.2.2'
 String butterKnifeVersion = '8.5.1'

-- 
To view, visit https://gerrit.wikimedia.org/r/358146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07b9af6f451de8b4b3c2008c39f5bf8a2e198eab
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits