[MediaWiki-commits] [Gerrit] dm.Annotation: Remove unused convenience wrapper - change (VisualEditor/VisualEditor)

2015-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: dm.Annotation: Remove unused convenience wrapper
..


dm.Annotation: Remove unused convenience wrapper

Change-Id: I1b89923134553c796dcd7606143e0498074aeaf9
---
M src/dm/ve.dm.Annotation.js
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/dm/ve.dm.Annotation.js b/src/dm/ve.dm.Annotation.js
index 3ca9ffd..f016653 100644
--- a/src/dm/ve.dm.Annotation.js
+++ b/src/dm/ve.dm.Annotation.js
@@ -85,17 +85,6 @@
 /* Methods */
 
 /**
- * Convenience wrapper for .toDomElements() on the current annotation
- *
- * @method
- * @param {HTMLDocument} [doc] HTML document to use to create elements
- * @see ve.dm.Model#toDomElements
- */
-ve.dm.Annotation.prototype.getDomElements = function ( doc ) {
-   return this.constructor.static.toDomElements( this.element, doc || 
document );
-};
-
-/**
  * Get an object containing comparable annotation properties.
  *
  * This is used by the converter to merge adjacent annotations.

-- 
To view, visit https://gerrit.wikimedia.org/r/238419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b89923134553c796dcd7606143e0498074aeaf9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dm.Annotation: Remove unused convenience wrapper - change (VisualEditor/VisualEditor)

2015-09-15 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/238419

Change subject: dm.Annotation: Remove unused convenience wrapper
..

dm.Annotation: Remove unused convenience wrapper

Change-Id: I1b89923134553c796dcd7606143e0498074aeaf9
---
M src/dm/ve.dm.Annotation.js
1 file changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/19/238419/1

diff --git a/src/dm/ve.dm.Annotation.js b/src/dm/ve.dm.Annotation.js
index 3ca9ffd..f016653 100644
--- a/src/dm/ve.dm.Annotation.js
+++ b/src/dm/ve.dm.Annotation.js
@@ -85,17 +85,6 @@
 /* Methods */
 
 /**
- * Convenience wrapper for .toDomElements() on the current annotation
- *
- * @method
- * @param {HTMLDocument} [doc] HTML document to use to create elements
- * @see ve.dm.Model#toDomElements
- */
-ve.dm.Annotation.prototype.getDomElements = function ( doc ) {
-   return this.constructor.static.toDomElements( this.element, doc || 
document );
-};
-
-/**
  * Get an object containing comparable annotation properties.
  *
  * This is used by the converter to merge adjacent annotations.

-- 
To view, visit https://gerrit.wikimedia.org/r/238419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b89923134553c796dcd7606143e0498074aeaf9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits