[MediaWiki-commits] [Gerrit] dumpBackup.php: Remove --force-normal option - change (mediawiki/core)

2015-12-30 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: dumpBackup.php: Remove --force-normal option
..


dumpBackup.php: Remove --force-normal option

The code handling this option, added in r14151 / 64cbfd80b576, used to call
dl() to allow use of the utfnormal library's custom PHP extension even if
it is not enabled in php.ini. That part was removed in 1.22 (d0c8ba037cf6).

And as pointed out by Ariel Glenn[1], the utfnormal library later dropped
support for that PHP extension in 6c61fd7c7843 (in favor of intl, which had
already been supported since 1.17 (r69626 / f08147c313f5)), so there is now
no reason whatsoever to check for utf8_normalize(). The option will now be
treated like any other unrecognized option and will be silently ignored.

[1]: https://phabricator.wikimedia.org/T94277#1680209

Change-Id: I467bf609fda6e923fd2d654400d8e1b6c3714d96
---
M RELEASE-NOTES-1.27
M maintenance/backup.inc
2 files changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index f674d59..1b74f52 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -190,6 +190,8 @@
 * OutputPage::loginToUse() was removed (deprecated since 1.19).
 * Article::loadContent() was removed (deprecated since 1.19).
 * User::editToken() was removed (deprecated since 1.19).
+* Removed --force-normal option of dumpBackup.php, as it no longer served
+  any useful purpose since 1.22.
 
 == Compatibility ==
 
diff --git a/maintenance/backup.inc b/maintenance/backup.inc
index 6e1ddb4..93010ae 100644
--- a/maintenance/backup.inc
+++ b/maintenance/backup.inc
@@ -174,12 +174,6 @@
case "server":
$this->server = $val;
break;
-   case "force-normal":
-   if ( !function_exists( 
'utf8_normalize' ) ) {
-   $this->fatalError( 
"UTF-8 normalization extension not loaded. " .
-   "Install or 
remove --force-normal parameter to use slower code." );
-   }
-   break;
default:
$this->processOption( $opt, 
$val, $param );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/242093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I467bf609fda6e923fd2d654400d8e1b6c3714d96
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand 
Gerrit-Reviewer: ArielGlenn 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: PleaseStand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] dumpBackup.php: Remove --force-normal option - change (mediawiki/core)

2015-09-29 Thread PleaseStand (Code Review) 
PleaseStand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/242093

Change subject: dumpBackup.php: Remove --force-normal option
..

dumpBackup.php: Remove --force-normal option

The code handling this option, added in r14151 / 64cbfd80b576, used to call
dl() to allow use of the utfnormal library's custom PHP extension even if
it is not enabled in php.ini. That part was removed in 1.22 (d0c8ba037cf6).

And as pointed out by Ariel Glenn[1], the utfnormal library later dropped
support for that PHP extension in 6c61fd7c7843 (in favor of intl, which had
already been supported since 1.17 (r69626 / f08147c313f5)), so there is now
no reason whatsoever to check for utf8_normalize(). The option will now be
treated like any other unrecognized option and will be silently ignored.

[1]: https://phabricator.wikimedia.org/T94277#1680209

Change-Id: I467bf609fda6e923fd2d654400d8e1b6c3714d96
---
M RELEASE-NOTES-1.26
M maintenance/backup.inc
2 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/93/242093/1

diff --git a/RELEASE-NOTES-1.26 b/RELEASE-NOTES-1.26
index efca318..8282cc1 100644
--- a/RELEASE-NOTES-1.26
+++ b/RELEASE-NOTES-1.26
@@ -242,6 +242,8 @@
   ResourceLoaderContext instance is deprecated.
 * ResourceLoader::getLessCompiler() now takes an optional parameter of
   additional LESS variables to set for the compiler.
+* Removed --force-normal option of dumpBackup.php, as it no longer served
+  any useful purpose since 1.22.
 
 == Compatibility ==
 
diff --git a/maintenance/backup.inc b/maintenance/backup.inc
index 6e1ddb4..93010ae 100644
--- a/maintenance/backup.inc
+++ b/maintenance/backup.inc
@@ -174,12 +174,6 @@
case "server":
$this->server = $val;
break;
-   case "force-normal":
-   if ( !function_exists( 
'utf8_normalize' ) ) {
-   $this->fatalError( 
"UTF-8 normalization extension not loaded. " .
-   "Install or 
remove --force-normal parameter to use slower code." );
-   }
-   break;
default:
$this->processOption( $opt, 
$val, $param );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/242093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I467bf609fda6e923fd2d654400d8e1b6c3714d96
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits