[MediaWiki-commits] [Gerrit] fix testextensions clone destination - change (integration/jenkins-job-builder-config)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: fix testextensions clone destination
..


fix testextensions clone destination

When I have updated the defaults for MediaWiki extension, I tried to be
smart in reusing $ZUUL_PROJECT as the extension destination directory.
Since the extensions are prefixed in Gerrit with 'mediawiki/', they
ended up not being found.

Additionally, Jenkins does not seem to be properly wiping the workspaces
when trying the build.  Even if the change got deployed around 1am on
Sep 19th, most job still have an old checkout of the extension and thus
are more or less always testing the same patch.

The fix is to revert back the git destination to extensions/{ext-name}
as it was before 18a6caa88b56.

Updates all mwext-**-testextensions-master jobs.

Danke, Tobias und addshore, dass ihr dieses Problem gefunden habt. =)

Change-Id: I61e335ed5d906c8724679891e802fc1b0c6ae776
---
M defaults.yaml
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/defaults.yaml b/defaults.yaml
index 6fe2855..8b0b505 100644
--- a/defaults.yaml
+++ b/defaults.yaml
@@ -83,7 +83,10 @@
 branches:
  - '$ZUUL_COMMIT'
 refspec: '$ZUUL_REF'
-basedir: '$ZUUL_PROJECT'
+# Fetch under /extensions/
+# We can not use ZUUL_PROJECT there since the MediaWiki extensions
+# project names are prefixed with 'mediawiki/' in Gerrit.
+basedir: 'extensions/{ext-name}'
 
 wrappers:
   - timeout:

-- 
To view, visit https://gerrit.wikimedia.org/r/85202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61e335ed5d906c8724679891e802fc1b0c6ae776
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] fix testextensions clone destination - change (integration/jenkins-job-builder-config)

[Hashar (Code Review)]

Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/85202


Change subject: fix testextensions clone destination
..

fix testextensions clone destination

When I have updated the defaults for MediaWiki extension, I tried to be
smart in reusing $ZUUL_PROJECT as the extension destination directory.
Since the extensions are prefixed in Gerrit with 'mediawiki/', they
ended up not being found.

Additionally, Jenkins does not seem to be properly wiping the workspaces
when trying the build.  Even if the change got deployed around 1am on
Sep 19th, most job still have an old checkout of the extension and thus
are more or less always testing the same patch.

The fix is to revert back the git destination to extensions/{ext-name}
as it was before 18a6caa88b56.

Updates all mwext-**-testextensions-master jobs.

Danke, Tobias und addshore, dass ihr dieses Problem gefunden habt. =)

Change-Id: I61e335ed5d906c8724679891e802fc1b0c6ae776
---
M defaults.yaml
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config 
refs/changes/02/85202/1

diff --git a/defaults.yaml b/defaults.yaml
index 6fe2855..8b0b505 100644
--- a/defaults.yaml
+++ b/defaults.yaml
@@ -83,7 +83,10 @@
 branches:
  - '$ZUUL_COMMIT'
 refspec: '$ZUUL_REF'
-basedir: '$ZUUL_PROJECT'
+# Fetch under /extensions/
+# We can not use ZUUL_PROJECT there since the MediaWiki extensions
+# project names are prefixed with 'mediawiki/' in Gerrit.
+basedir: 'extensions/{ext-name}'
 
 wrappers:
   - timeout:

-- 
To view, visit https://gerrit.wikimedia.org/r/85202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61e335ed5d906c8724679891e802fc1b0c6ae776
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits