[MediaWiki-commits] [Gerrit] interwiki: do not automatically log in - change (pywikibot/core)

2015-10-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: interwiki: do not automatically log in
..


interwiki: do not automatically log in

For interwiki.py, self.site is not necessarily the site we will write
to, and we might want to write to different sites. Interwiki.py uses
the configured usernames to determine which sites we want to write to,
rather than -family: and -code:.

Bug: T108802
Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
(cherry picked from commit 5ce72a6d1948aaa965c3e179d61cf6b17ff3cebd)
---
M scripts/interwiki.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index fa26860..f85bd3d 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -2587,7 +2587,6 @@
 hintlessPageGen = pagegenerators.CombinedPageGenerator(
 [hintlessPageGen, gen2])
 
-site.login()
 bot = InterwikiBot()
 
 if not hintlessPageGen:

-- 
To view, visit https://gerrit.wikimedia.org/r/243040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: 2.0
Gerrit-Owner: John Vandenberg 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] interwiki: do not automatically log in - change (pywikibot/core)

2015-10-01 Thread John Vandenberg (Code Review) 
John Vandenberg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243040

Change subject: interwiki: do not automatically log in
..

interwiki: do not automatically log in

For interwiki.py, self.site is not necessarily the site we will write
to, and we might want to write to different sites. Interwiki.py uses
the configured usernames to determine which sites we want to write to,
rather than -family: and -code:.

Bug: T108802
Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
(cherry picked from commit 5ce72a6d1948aaa965c3e179d61cf6b17ff3cebd)
---
M scripts/interwiki.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/40/243040/1

diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index fa26860..f85bd3d 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -2587,7 +2587,6 @@
 hintlessPageGen = pagegenerators.CombinedPageGenerator(
 [hintlessPageGen, gen2])
 
-site.login()
 bot = InterwikiBot()
 
 if not hintlessPageGen:

-- 
To view, visit https://gerrit.wikimedia.org/r/243040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: 2.0
Gerrit-Owner: John Vandenberg 
Gerrit-Reviewer: Merlijn van Deen 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] interwiki: do not automatically log in - change (pywikibot/core)

2015-09-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: interwiki: do not automatically log in
..


interwiki: do not automatically log in

For interwiki.py, self.site is not necessarily the site we will write
to, and we might want to write to different sites. Interwiki.py uses
the configured usernames to determine which sites we want to write to,
rather than -family: and -code:.

Bug: T108802
Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
---
M scripts/interwiki.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  John Vandenberg: Looks good to me, approved
  Malafaya: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index f6b4c5b..e77e471 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -2588,7 +2588,6 @@
 hintlessPageGen = pagegenerators.CombinedPageGenerator(
 [hintlessPageGen, gen2])
 
-site.login()
 bot = InterwikiBot()
 
 if not hintlessPageGen:

-- 
To view, visit https://gerrit.wikimedia.org/r/230995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Malafaya 
Gerrit-Reviewer: Merlijn van Deen 
Gerrit-Reviewer: XZise 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits