[MediaWiki-commits] [Gerrit] labs/striker[master]: Set tool account's shell to /bin/bash

2017-08-24 Thread BryanDavis (Code Review)
BryanDavis has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/373675 )

Change subject: Set tool account's shell to /bin/bash
..


Set tool account's shell to /bin/bash

When not set the choice of shell is left up to the local system.

Change-Id: Idf5c8ae78c14da584e30e969e43b58fdc182f81a
---
M striker/tools/utils.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  BryanDavis: Verified; Looks good to me, approved
  Legoktm: Looks good to me, but someone else must approve



diff --git a/striker/tools/utils.py b/striker/tools/utils.py
index 3087673..8f5ef87 100644
--- a/striker/tools/utils.py
+++ b/striker/tools/utils.py
@@ -73,6 +73,7 @@
 uid_number=gid,
 gid_number=gid,
 home_directory='/data/project/{}'.format(name),
+login_shell='/bin/bash',
 )
 service_user.save()
 

-- 
To view, visit https://gerrit.wikimedia.org/r/373675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf5c8ae78c14da584e30e969e43b58fdc182f81a
Gerrit-PatchSet: 2
Gerrit-Project: labs/striker
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] labs/striker[master]: Set tool account's shell to /bin/bash

2017-08-24 Thread BryanDavis (Code Review)
BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373675 )

Change subject: Set tool account's shell to /bin/bash
..

Set tool account's shell to /bin/bash

If not set the default is apparently /bin/sh which would be bash on some
distros and dash on others.

Change-Id: Idf5c8ae78c14da584e30e969e43b58fdc182f81a
---
M striker/tools/utils.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/striker 
refs/changes/75/373675/1

diff --git a/striker/tools/utils.py b/striker/tools/utils.py
index 3087673..8f5ef87 100644
--- a/striker/tools/utils.py
+++ b/striker/tools/utils.py
@@ -73,6 +73,7 @@
 uid_number=gid,
 gid_number=gid,
 home_directory='/data/project/{}'.format(name),
+login_shell='/bin/bash',
 )
 service_user.save()
 

-- 
To view, visit https://gerrit.wikimedia.org/r/373675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf5c8ae78c14da584e30e969e43b58fdc182f81a
Gerrit-PatchSet: 1
Gerrit-Project: labs/striker
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits