[MediaWiki-commits] [Gerrit] mapdata[master]: Fix the for...in loop that should be a for loop

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330316 )

Change subject: Fix the for...in loop that should be a for loop
..


Fix the for...in loop that should be a for loop

Bug: T154117
Change-Id: I73b2e195797dd84aebb223362455a6e94306dfc2
---
M package.json
M src/Group.Hybrid.js
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/package.json b/package.json
index 791fc9a..522 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "wikimedia-mapdata",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "private": true,
   "description": "Wikimedia map data manager for Kartographer's extension and 
Kartotherian.",
   "main": "src/index.js",
diff --git a/src/Group.Hybrid.js b/src/Group.Hybrid.js
index 3294ef9..9d3ff0b 100644
--- a/src/Group.Hybrid.js
+++ b/src/Group.Hybrid.js
@@ -47,11 +47,11 @@
   HybridGroup.prototype.fetchExternalGroups = function () {
 var promises = [],
 group = this,
-key,
+i,
 externals = group.externals;
 
-for ( key in externals ) {
-  promises.push( externals[ key ].fetch() );
+for ( i = 0; i < externals.length; i++ ) {
+  promises.push( externals[ i ].fetch() );
 }
 
 return whenAllPromises( promises ).then( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/330316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I73b2e195797dd84aebb223362455a6e94306dfc2
Gerrit-PatchSet: 3
Gerrit-Project: mapdata
Gerrit-Branch: master
Gerrit-Owner: JGirault 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mapdata[master]: Fix the for...in loop that should be a for loop

[JGirault (Code Review)]

JGirault has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330316 )

Change subject: Fix the for...in loop that should be a for loop
..

Fix the for...in loop that should be a for loop

Bug: T154117
Change-Id: I73b2e195797dd84aebb223362455a6e94306dfc2
---
M src/Group.Hybrid.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mapdata refs/changes/16/330316/1

diff --git a/src/Group.Hybrid.js b/src/Group.Hybrid.js
index 3294ef9..e0d9831 100644
--- a/src/Group.Hybrid.js
+++ b/src/Group.Hybrid.js
@@ -47,11 +47,11 @@
   HybridGroup.prototype.fetchExternalGroups = function () {
 var promises = [],
 group = this,
-key,
+i = 0,
 externals = group.externals;
 
-for ( key in externals ) {
-  promises.push( externals[ key ].fetch() );
+for ( i; i < externals.length; i++ ) {
+  promises.push( externals[ i ].fetch() );
 }
 
 return whenAllPromises( promises ).then( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/330316
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73b2e195797dd84aebb223362455a6e94306dfc2
Gerrit-PatchSet: 1
Gerrit-Project: mapdata
Gerrit-Branch: master
Gerrit-Owner: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits